From: Anton Blanchard <anton@samba.org>
To: behanw@converseincode.com, ying.huang@intel.com,
a.p.zijlstra@chello.nl, akpm@linux-foundation.org,
oleg@redhat.com, Segher Boessenkool <segher@kernel.crashing.org>,
mingo@elte.hu
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: llist code relies on undefined behaviour, upsets llvm/clang
Date: Mon, 16 Jan 2017 08:36:00 +1100 [thread overview]
Message-ID: <20170116083600.47175073@kryten> (raw)
Hi,
I was debugging a hang on a ppc64le kernel built with clang, and it
looks to be undefined behaviour with pointer wrapping in the llist code.
A test case is below. llist_for_each_entry() does container_of() on a
NULL pointer, which wraps our pointer negative, then adds the same
offset back in and expects to get back to NULL. Unfortunately clang
decides that this can never be NULL and optimises it into an infinite
loop.
Build with -DFIX, such that the llist_node has a zero offset from the
start of the struct, and things work.
Is anyone other than ppc64le building kernels with llvm/clang these
days? This should reproduce on ARM64 and x86-64.
Anton
--
#include <stdio.h>
#define __compiler_offsetof(a, b) \
__builtin_offsetof(a, b)
#undef offsetof
#ifdef __compiler_offsetof
#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER)
#else
#define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER)
#endif
struct llist_node {
struct llist_node *next;
};
#define container_of(ptr, type, member) ({ \
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
(type *)( (char *)__mptr - offsetof(type,member) );})
#define llist_entry(ptr, type, member) \
container_of(ptr, type, member)
#define llist_for_each_entry(pos, node, member) \
for ((pos) = llist_entry((node), typeof(*(pos)), member); \
&(pos)->member != NULL; \
(pos) = llist_entry((pos)->member.next, typeof(*(pos)), member))
struct foo {
#ifndef FIX
unsigned long a;
#endif
struct llist_node ll;
};
void working(void);
struct llist_node *ptr;
void bar(void)
{
struct foo *f;
llist_for_each_entry(f, ptr, ll) {
}
working();
}
next reply other threads:[~2017-01-15 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 21:36 Anton Blanchard [this message]
2017-01-16 9:05 ` llist code relies on undefined behaviour, upsets llvm/clang Peter Zijlstra
2017-01-16 11:42 ` Anton Blanchard
2017-01-16 12:53 ` Peter Zijlstra
2017-01-16 13:09 ` Andrey Ryabinin
2017-01-16 14:34 ` David Laight
2017-01-16 14:34 ` David Laight
2017-01-16 16:25 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116083600.47175073@kryten \
--to=anton@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=behanw@converseincode.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=segher@kernel.crashing.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.