From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751009AbdAPJ2m (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Jan 2017 04:28:42 -0500
Received: from mail.kernel.org ([198.145.29.136]:54652 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750817AbdAPJ2k (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Jan 2017 04:28:40 -0500
Date: Mon, 16 Jan 2017 11:28:40 +0200
From: Leon Romanovsky <leon@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Michal Hocko <mhocko@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
        Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check
Message-ID: <20170116092840.GC32481@mtr-leonro.local>
References: <20170116091643.15260-1-bp@alien8.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="lCAWRPmW1mITcIfM"
Content-Disposition: inline
In-Reply-To: <20170116091643.15260-1-bp@alien8.de>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--lCAWRPmW1mITcIfM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 16, 2017 at 10:16:43AM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> We wanna know who's doing such a thing. Like slab.c does that.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  mm/slub.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 067598a00849..1b0fa7625d6d 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node)
>  		flags &= ~GFP_SLAB_BUG_MASK;
>  		pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
>  				invalid_mask, &invalid_mask, flags, &flags);
> +		dump_stack();

Will it make sense to change these two lines above to WARN(true, .....)?

>  	}
>
>  	return allocate_slab(s,
> --
> 2.11.0
>

--lCAWRPmW1mITcIfM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlh8kkcACgkQ5GN7iDZy
WKfYuhAApFfofFIU7vuBSuz6np7vAmzyYml2kLuuZuzhG2FC7aDOALyqrLwdSEuz
zmSQ6y1nua3NakwP5cG+K//PNaZ3+6uqheTG71gj6bb6LtswKWl2VRGbCmiJZmd4
wCogeKjqvQi0wwfd1gA3Ly7FMFZMwOdb+luNOnYY7Z0rp6wLVJCPw+Cez7MBpqcZ
yOutkbGqbYhPJ8MWi1JzYj6V/DJ1+RQqe8wEAdJ2zB1GYwPU8ypRKShyDDczg7Mf
+Tk9aV6r47RX7csS4qb9ZKebeoRdBSlT2CqKULoNqTBELlcOwuXbrATr/PuhT074
G+qWxdwq6eoN0irwP+ySokBNJIle2w/k1hjjx7FkiWngxxHTOXCiyeNw2antgQlG
yFluQurX7ApvxswuIguoTd7GHyzexq14F7Go3SXv8gLti2rXqTug7MUaSuQmQvEW
8nJVfI843CEWBHS/QxClBaPqqqnJ4IzYYT6PJ4tZtFBAjiH+792gqDSW0uSHP/tm
LLxqiO2yYDf/wBqh1EjZoTTm2Di93jrrFb/ZrsDi5IEKbdLtPe+xQqjeUmLMvMxD
FEMMl9VvOKlQ0FHmvYSpT07xkdA+HMqKWa/TtJqPq+wm0QDwbFvxy/cILZTm0IUx
YcdYgHRwKfoNHlivbnmtH1C3jOClaWqBO5wd+DHVDyN4MHxUslQ=
=+zKe
-----END PGP SIGNATURE-----

--lCAWRPmW1mITcIfM--