From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] scripts: check cc stable mailing list in commit Date: Mon, 16 Jan 2017 17:51:52 +0800 Message-ID: <20170116095152.GQ9770@yliu-dev.sh.intel.com> References: <1479768194-6255-1-git-send-email-thomas.monjalon@6wind.com> <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ferruh Yigit , dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id ECEDC108F for ; Mon, 16 Jan 2017 10:49:39 +0100 (CET) Content-Disposition: inline In-Reply-To: <1b249c77-5685-8492-6f6b-3478a2731267@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 30, 2016 at 02:54:14PM +0000, Ferruh Yigit wrote: > On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > > Add a check for commits fixing a released bug. > > Such commits are found thanks to scripts/git-log-fixes.sh. > > They must be sent CC: stable@dpdk.org. > > In order to avoid forgetting CC, this mail header can be written > > in the git commit message. > > > > Signed-off-by: Thomas Monjalon > > I think this is useful, thanks for the patch. Yes, it is. Thanks! (Sorry for late reply; hope it's not too late). > > +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n" > > This is good for developer, but since "CC: xx" tags removed when patch > applied, Again, I'd suggest to __not__ remove such tag. Firstly, why bother? And I will talk why this tag should be kept, as a stable tree maintainer. At the beginning, when people are not used to add "cc: stable" tag, I used to pick bug fix commits from master by something like: list all bug fixing patches and pick those that appliable to previous release. Later, kudos to Thomas, who wrote an handy script (git-log-fixes.sh) to do both, it indeeded make my life much easier. But it's still not enough. It lists a lot of patches (206 fix patches, while 728 in total: the ratio is near 30%): $ devtools/git-log-fixes.sh v16.07..v16.11 | wc -l 206 $ git rev-list v16.07..v16.11 | wc -l 728 Thus I dropped few of them, manually, resulting to 130 (still looks like a big number to me): $ git rev-list v16.07..v16.07.2 | wc -l 130 The policy I would expect is, leave this tag as it is, I then will apply all of them to a stable branch: I will no longer do the picking job. Instead, I may just need handle those can't apply cleanly and ask the author to do backport. It would be do-able now, as I saw a lot of people are getting used to add such tag. And even not, I saw those kind committers do that for them. Besides, if there is already an explicit way, why should we stick on the implicit way? --yliu > this will generate warnings when run against existing history. > > I don't know what can be done for this. > > Or should we keep CC: tags in commit log perhaps? > > >