All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: amelie.delaunay@st.com
Cc: rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [bug report] rtc: add STM32 RTC driver
Date: Mon, 16 Jan 2017 15:21:28 +0300	[thread overview]
Message-ID: <20170116122128.GC4104@mwanda> (raw)
In-Reply-To: <20170116121346.GA28569@mwanda>

Oh.  That still won't fix this:

drivers/rtc/rtc-stm32.c
   519          /*
   520           * Can't find a 1Hz, so give priority to RTC power consumption
   521           * by choosing the higher possible value for prediv_a
   522           */
   523          if ((pred_s > pred_s_max) || (pred_a > pred_a_max)) {
   524                  pred_a = pred_a_max;
   525                  pred_s = (rate / (pred_a + 1)) - 1;
   526  
   527                  dev_warn(&pdev->dev, "ck_rtc is %s\n",
   528                           (rate - ((pred_a + 1) * (pred_s + 1)) < 0) ?

This is type promoted to unsigned int < 0.

   529                           "fast" : "slow");
   530          }

regards,
dan carpenter

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  parent reply	other threads:[~2017-01-16 12:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 12:13 [rtc-linux] [bug report] rtc: add STM32 RTC driver Dan Carpenter
2017-01-16 12:19 ` [rtc-linux] " Amelie DELAUNAY
2017-01-16 12:21 ` Dan Carpenter [this message]
2017-01-16 12:26   ` [rtc-linux] " Amelie DELAUNAY
2017-01-16 12:29     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116122128.GC4104@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=amelie.delaunay@st.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.