Re: [Qemu-devel] [PATCH 11/16] block: explicitly acquire aiocontext in callbacks that need it

[Fam Zheng <famz@redhat.com>]

On Fri, 01/13 14:17, Paolo Bonzini wrote:
> diff --git a/nbd/server.c b/nbd/server.c
> index efe5cb8..08fb720 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -1366,6 +1366,10 @@ static void nbd_restart_write(void *opaque)
>  static void nbd_set_handlers(NBDClient *client)
>  {
>      if (client->exp && client->exp->ctx) {
> +        /* Note that the handlers do not expect any concurrency; qemu-nbd
> +         * does not instantiate multiple AioContexts yet, nor does it call
> +         * aio_poll/aio_dispatch from multiple threads.
> +         */
>          aio_set_fd_handler(client->exp->ctx, client->sioc->fd, true,
>                             client->can_read ? nbd_read : NULL,
>                             client->send_coroutine ? nbd_restart_write : NULL,

What about the built-in server (QMP nbd_server_start)?

> -- 
> 2.9.3
> 
>