From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdAPNqT (ORCPT ); Mon, 16 Jan 2017 08:46:19 -0500 Received: from mga02.intel.com ([134.134.136.20]:42158 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbdAPNqR (ORCPT ); Mon, 16 Jan 2017 08:46:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,239,1477983600"; d="scan'208";a="1113409325" Date: Mon, 16 Jan 2017 15:46:12 +0200 From: Jarkko Sakkinen To: "Maciej S. Szmigiero" Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel , Peter Huewe , Marcel Selhorst , Christophe Ricard , Jason Gunthorpe Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Message-ID: <20170116134612.uuzbb6xi7pw7czyo@intel.com> References: <20170116094202.bng7zfznepw7s5la@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116094202.bng7zfznepw7s5la@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: > On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM > > access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no > > longer works. > > The initialization proceeds fine until we get and start using chip-reported > > timeouts - and the chip reports C and D timeouts of zero. > > > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic > > means to override the chip returned timeouts") we had actually let default > > timeout values remain in this case, so let's bring back this behavior to > > make chips like Atmel 3203 work again. > > > > Use a common code that was introduced by that commit so a warning is > > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the > > timeouts aren't chip-original. > > > > Signed-off-by: Maciej S. Szmigiero > > > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") > > Cc: stable@vger.kernel.org > > Reviewed-by: Jarkko Sakkinen It's now applied to my master branch so if someone wants to test it, it should be fairly easy. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Date: Mon, 16 Jan 2017 15:46:12 +0200 Message-ID: <20170116134612.uuzbb6xi7pw7czyo@intel.com> References: <20170116094202.bng7zfznepw7s5la@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170116094202.bng7zfznepw7s5la-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Maciej S. Szmigiero" Cc: Christophe Ricard , linux-kernel , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: > On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM > > access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no > > longer works. > > The initialization proceeds fine until we get and start using chip-reported > > timeouts - and the chip reports C and D timeouts of zero. > > > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic > > means to override the chip returned timeouts") we had actually let default > > timeout values remain in this case, so let's bring back this behavior to > > make chips like Atmel 3203 work again. > > > > Use a common code that was introduced by that commit so a warning is > > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the > > timeouts aren't chip-original. > > > > Signed-off-by: Maciej S. Szmigiero > > > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Reviewed-by: Jarkko Sakkinen It's now applied to my master branch so if someone wants to test it, it should be fairly easy. /Jarkko ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi