From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Date: Mon, 16 Jan 2017 07:51:10 -0800 Message-ID: <20170116155110.GA13495@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> <20170113180602.GA30346@infradead.org> <587C61B3.3070107@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <587C61B3.3070107@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kishon Vijay Abraham I Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Christoph Hellwig , linux-samsung-soc@vger.kernel.org, Jingoo Han , Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Mon, Jan 16, 2017 at 11:31:23AM +0530, Kishon Vijay Abraham I wrote: > Actually not all devices have hardcoded headers. E.g the platform I'm using > doesn't have hardcoded headers and it can be configured based on the function > the user would like to use. If the devices are hardcoded, then using configfs > can be skipped altogether. In such cases, APIs like pci_epf_create() can > directly be used by the drivers instead of going via configfs. That's exactly what I meant - the IDs need to be set by the driver for the implemented PCI device, and it's not up to the gadget core to configur e them, it's up to the implementation of the PCIe device which PCI it exposes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbdAPPvZ (ORCPT ); Mon, 16 Jan 2017 10:51:25 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:43816 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdAPPvU (ORCPT ); Mon, 16 Jan 2017 10:51:20 -0500 Date: Mon, 16 Jan 2017 07:51:10 -0800 From: Christoph Hellwig To: Kishon Vijay Abraham I Cc: Christoph Hellwig , Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Message-ID: <20170116155110.GA13495@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> <20170113180602.GA30346@infradead.org> <587C61B3.3070107@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <587C61B3.3070107@ti.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 11:31:23AM +0530, Kishon Vijay Abraham I wrote: > Actually not all devices have hardcoded headers. E.g the platform I'm using > doesn't have hardcoded headers and it can be configured based on the function > the user would like to use. If the devices are hardcoded, then using configfs > can be skipped altogether. In such cases, APIs like pci_epf_create() can > directly be used by the drivers instead of going via configfs. That's exactly what I meant - the IDs need to be set by the driver for the implemented PCI device, and it's not up to the gadget core to configur e them, it's up to the implementation of the PCIe device which PCI it exposes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Mon, 16 Jan 2017 07:51:10 -0800 From: Christoph Hellwig To: Kishon Vijay Abraham I Subject: Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions Message-ID: <20170116155110.GA13495@infradead.org> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> <20170113180602.GA30346@infradead.org> <587C61B3.3070107@ti.com> MIME-Version: 1.0 In-Reply-To: <587C61B3.3070107@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Christoph Hellwig , linux-samsung-soc@vger.kernel.org, Jingoo Han , Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Mon, Jan 16, 2017 at 11:31:23AM +0530, Kishon Vijay Abraham I wrote: > Actually not all devices have hardcoded headers. E.g the platform I'm using > doesn't have hardcoded headers and it can be configured based on the function > the user would like to use. If the devices are hardcoded, then using configfs > can be skipped altogether. In such cases, APIs like pci_epf_create() can > directly be used by the drivers instead of going via configfs. That's exactly what I meant - the IDs need to be set by the driver for the implemented PCI device, and it's not up to the gadget core to configur e them, it's up to the implementation of the PCIe device which PCI it exposes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@infradead.org (Christoph Hellwig) Date: Mon, 16 Jan 2017 07:51:10 -0800 Subject: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions In-Reply-To: <587C61B3.3070107@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-17-git-send-email-kishon@ti.com> <20170113180602.GA30346@infradead.org> <587C61B3.3070107@ti.com> Message-ID: <20170116155110.GA13495@infradead.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 16, 2017 at 11:31:23AM +0530, Kishon Vijay Abraham I wrote: > Actually not all devices have hardcoded headers. E.g the platform I'm using > doesn't have hardcoded headers and it can be configured based on the function > the user would like to use. If the devices are hardcoded, then using configfs > can be skipped altogether. In such cases, APIs like pci_epf_create() can > directly be used by the drivers instead of going via configfs. That's exactly what I meant - the IDs need to be set by the driver for the implemented PCI device, and it's not up to the gadget core to configur e them, it's up to the implementation of the PCIe device which PCI it exposes.