From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdAPQk2 (ORCPT ); Mon, 16 Jan 2017 11:40:28 -0500 Received: from mga01.intel.com ([192.55.52.88]:47177 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbdAPQjc (ORCPT ); Mon, 16 Jan 2017 11:39:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="53638113" Date: Mon, 16 Jan 2017 18:39:27 +0200 From: Jarkko Sakkinen To: "Maciej S. Szmigiero" Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel , Peter Huewe , Marcel Selhorst , Christophe Ricard , Jason Gunthorpe Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Message-ID: <20170116163927.od5coufxvctgknot@intel.com> References: <20170116094202.bng7zfznepw7s5la@intel.com> <20170116134612.uuzbb6xi7pw7czyo@intel.com> <20170116135539.4qtrylwt3m2yfapx@intel.com> <17fd82a8-d6fd-d4ec-0965-3ebba25fca0e@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17fd82a8-d6fd-d4ec-0965-3ebba25fca0e@maciej.szmigiero.name> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 03:58:26PM +0100, Maciej S. Szmigiero wrote: > On 16.01.2017 14:55, Jarkko Sakkinen wrote: > > On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote: > >> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: > >>> On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: > >>>> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM > >>>> access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no > >>>> longer works. > >>>> The initialization proceeds fine until we get and start using chip-reported > >>>> timeouts - and the chip reports C and D timeouts of zero. > >>>> > >>>> It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic > >>>> means to override the chip returned timeouts") we had actually let default > >>>> timeout values remain in this case, so let's bring back this behavior to > >>>> make chips like Atmel 3203 work again. > >>>> > >>>> Use a common code that was introduced by that commit so a warning is > >>>> printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the > >>>> timeouts aren't chip-original. > >>>> > >>>> Signed-off-by: Maciej S. Szmigiero > >>>> > >>>> Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") > >>>> Cc: stable@vger.kernel.org > >>> > >>> Reviewed-by: Jarkko Sakkinen > >> > >> It's now applied to my master branch so if someone wants to > >> test it, it should be fairly easy. > > > > And I decided to squash the rename commit to it. > > Wouldn't it be better to squash the rename commit into "fix iTPM probe via > probe_itpm() function" patch (if it isn't too late), since they touch the > same functionality? It can be renamed, modified and even dropped as long as it is in my master branch and I haven't sent pull request to James Morris. /Jarkkok From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Date: Mon, 16 Jan 2017 18:39:27 +0200 Message-ID: <20170116163927.od5coufxvctgknot@intel.com> References: <20170116094202.bng7zfznepw7s5la@intel.com> <20170116134612.uuzbb6xi7pw7czyo@intel.com> <20170116135539.4qtrylwt3m2yfapx@intel.com> <17fd82a8-d6fd-d4ec-0965-3ebba25fca0e@maciej.szmigiero.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <17fd82a8-d6fd-d4ec-0965-3ebba25fca0e-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Maciej S. Szmigiero" Cc: Christophe Ricard , linux-kernel , tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net On Mon, Jan 16, 2017 at 03:58:26PM +0100, Maciej S. Szmigiero wrote: > On 16.01.2017 14:55, Jarkko Sakkinen wrote: > > On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote: > >> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: > >>> On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: > >>>> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM > >>>> access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no > >>>> longer works. > >>>> The initialization proceeds fine until we get and start using chip-reported > >>>> timeouts - and the chip reports C and D timeouts of zero. > >>>> > >>>> It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic > >>>> means to override the chip returned timeouts") we had actually let default > >>>> timeout values remain in this case, so let's bring back this behavior to > >>>> make chips like Atmel 3203 work again. > >>>> > >>>> Use a common code that was introduced by that commit so a warning is > >>>> printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the > >>>> timeouts aren't chip-original. > >>>> > >>>> Signed-off-by: Maciej S. Szmigiero > >>>> > >>>> Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") > >>>> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > >>> > >>> Reviewed-by: Jarkko Sakkinen > >> > >> It's now applied to my master branch so if someone wants to > >> test it, it should be fairly easy. > > > > And I decided to squash the rename commit to it. > > Wouldn't it be better to squash the rename commit into "fix iTPM probe via > probe_itpm() function" patch (if it isn't too late), since they touch the > same functionality? It can be renamed, modified and even dropped as long as it is in my master branch and I haven't sent pull request to James Morris. /Jarkkok ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot