From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Greer Subject: Re: [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume() Date: Mon, 16 Jan 2017 10:49:35 -0700 Message-ID: <20170116174935.GC27262@animalcreek.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52783 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbdAPRth (ORCPT ); Mon, 16 Jan 2017 12:49:37 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Liam Breck Cc: linux-pm@vger.kernel.org, Sebastian Reichel , Tony Lindgren , Liam Breck , Matt Ranostay On Sun, Jan 15, 2017 at 10:07:34PM -0800, Liam Breck wrote: > > pm_resume() does a register_reset() which clears charger host mode. > > Fix by calling set_mode_host() after the reset. > > Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger") > Cc: Mark A. Greer > Cc: Matt Ranostay > Cc: Tony Lindgren > Signed-off-by: Liam Breck > --- > drivers/power/supply/bq24190_charger.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index f5746b9..e9e6fe9 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -1494,6 +1494,7 @@ static int bq24190_pm_resume(struct device *dev) > > pm_runtime_get_sync(bdi->dev); > bq24190_register_reset(bdi); > + bq24190_set_mode_host(bdi); > pm_runtime_put_sync(bdi->dev); > > /* Things may have changed while suspended so alert upper layer */ Acked-by: Mark Greer