From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Greer Subject: Re: [PATCH v2 3/6] power: bq24190_charger: Install irq_handler_thread() at end of probe() Date: Mon, 16 Jan 2017 11:03:13 -0700 Message-ID: <20170116180313.GD27262@animalcreek.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51794 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdAPSDP (ORCPT ); Mon, 16 Jan 2017 13:03:15 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Liam Breck Cc: linux-pm@vger.kernel.org, Sebastian Reichel , Tony Lindgren , Liam Breck , Matt Ranostay On Sun, Jan 15, 2017 at 10:07:48PM -0800, Liam Breck wrote: > > The device specific data is not fully initialized on > request_threaded_irq(). This may cause a crash when the IRQ handler > tries to reference them. > > Fix the issue by installing IRQ handler at the end of the probe. > > Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger") > Cc: Mark A. Greer > Cc: Matt Ranostay > Cc: Tony Lindgren > Signed-off-by: Liam Breck > --- > drivers/power/supply/bq24190_charger.c | 35 ++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c > index b51eac1..54c8952 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > out4: > - power_supply_unregister(bdi->battery); > + bq24190_sysfs_remove_group(bdi); > + > out3: > - power_supply_unregister(bdi->charger); > + power_supply_unregister(bdi->battery); > + > out2: > - pm_runtime_disable(dev); > + power_supply_unregister(bdi->charger); > + > out1: > + pm_runtime_disable(dev); > if (bdi->gpio_int) > gpio_free(bdi->gpio_int); > - > return ret; > } I don't like the reformatting that you did here and even if I did, it should be done in a separate patch. But, its minor so... Acked-by: Mark Greer