From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdAPSc6 (ORCPT ); Mon, 16 Jan 2017 13:32:58 -0500 Received: from mail.kernel.org ([198.145.29.136]:35962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbdAPSc4 (ORCPT ); Mon, 16 Jan 2017 13:32:56 -0500 Date: Mon, 16 Jan 2017 15:32:29 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Peter Zijlstra , Ingo Molnar , Namhyung Kim Subject: Re: [PATCH perf/core v2 1/4] perf-probe: Fix to show correct locations for events on modules Message-ID: <20170116183229.GA4159@kernel.org> References: <148411429514.9978.10060675441541429175.stgit@devbox> <148411436777.9978.1440275861947194930.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148411436777.9978.1440275861947194930.stgit@devbox> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jan 11, 2017 at 02:59:38PM +0900, Masami Hiramatsu escreveu: > Fix to show correct locations for events on modules by relocating > given address instead of retrying after failure. > > This happens when the module text size is enough big, bigger than > sh_addr, because original code retries withgiven address + sh_addr > if it failed to find CU DIE at the given address. Any address > smaller than sh_addr always fails and it retries with correct > address, but the address which bigger than sh_addr will get a CU > DIE which is on given address (not adjusted by sh_addr). Tested and applied, - Arnaldo