All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <pmac@au1.ibm.com>
Subject: Re: [PATCH] powerpc/icp-opal: Fix missing KVM case and harden replay
Date: Tue, 17 Jan 2017 12:08:32 +0530	[thread overview]
Message-ID: <20170117063832.GA8963@dhcp-9-109-223-248.in.ibm.com> (raw)
In-Reply-To: <20170116175853.2458-1-benh@kernel.crashing.org>

On Mon, Jan 16, 2017 at 11:58:53AM -0600, Benjamin Herrenschmidt wrote:
> The icp-opal call is missing the code from icp-native to recover
> interrupts snatched by KVM. Without that, when running KVM, we can
> get into a situation where an interrupt is lost and the CPU stuck
> with an elevated CPPR.
> 
> Also harden replay by always checking the return from opal_int_eoi
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---

Looks good to me

Acked-by: Balbir Singh <bsingharora@gmail.com>

  reply	other threads:[~2017-01-17  6:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 17:58 [PATCH] powerpc/icp-opal: Fix missing KVM case and harden replay Benjamin Herrenschmidt
2017-01-17  6:38 ` Balbir Singh [this message]
2017-01-18 12:10 ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2017-01-16  2:19 [PATCH] " Benjamin Herrenschmidt
2017-01-16 16:07 ` Balbir Singh
2017-01-16 17:57   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117063832.GA8963@dhcp-9-109-223-248.in.ibm.com \
    --to=bsingharora@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=pmac@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.