All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Ronco <c.ronco@kerlink.fr>
To: ofono@ofono.org
Subject: [PATCH 0/1] use g_timeout_add instead of usleep
Date: Tue, 17 Jan 2017 11:29:03 +0100	[thread overview]
Message-ID: <20170117102904.970-1-c.ronco@kerlink.fr> (raw)
In-Reply-To: <9c2461b9-0b37-9b8d-ce56-833f4fb2e1fc@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Here is another version of the patch using g_timeout_add.
Compare to what is done in at_util_sim_state_query, I choose to wait
only 20ms between attempts (2s in at_util_sim_state_query).
On my modem, I manage to recover from temporary error after 7 to 10
tries (less than 2 seconds).
Let me know if you prefer a bigger wait before retry.

Christophe Ronco (1):
  qmimodem: query_passwd_state can be retried

 drivers/qmimodem/sim.c | 95 ++++++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 81 insertions(+), 14 deletions(-)

-- 
2.11.0


  reply	other threads:[~2017-01-17 10:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 10:55 [PATCH 0/1] add send_passwd feature to qmimodem sim driver Christophe Ronco
2017-01-03 10:55 ` [PATCH 1/1] MC7430: Add " Christophe Ronco
2017-01-03 16:54   ` Denis Kenzior
2017-01-10  8:38     ` [PATCH 0/4] Add pin_send " Christophe Ronco
2017-01-10  8:38       ` [PATCH 1/4] qmimodem: get password state from modem Christophe Ronco
2017-01-10 17:19         ` Denis Kenzior
2017-01-11 10:06           ` [PATCH 0/1] Correction of previous patch Christophe Ronco
2017-01-11 10:06             ` [PATCH 1/1] qmimodem: get password state from modem Christophe Ronco
2017-01-11 16:00               ` Denis Kenzior
2017-01-12 14:09                 ` [PATCH 0/1] Patch #3 resubmitted Christophe Ronco
2017-01-12 14:09                   ` [PATCH 1/1] qmimodem: query_passwd_state can be retried Christophe Ronco
2017-01-13 22:25                     ` Denis Kenzior
2017-01-17 10:29                       ` Christophe Ronco [this message]
2017-01-17 10:29                         ` Christophe Ronco
2017-01-17  4:26                           ` Denis Kenzior
2017-01-10  8:38       ` [PATCH 2/4] qmimodem: add pin_send feature Christophe Ronco
2017-01-10 17:21         ` Denis Kenzior
2017-01-10  8:38       ` [PATCH 3/4] qmimodem: query_passwd_state can be retried Christophe Ronco
2017-01-10  8:38       ` [PATCH 4/4] udevng: Sierra modems use SIM driver Christophe Ronco
2017-01-10 17:26         ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117102904.970-1-c.ronco@kerlink.fr \
    --to=c.ronco@kerlink.fr \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.