From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751240AbdAQSSe (ORCPT ); Tue, 17 Jan 2017 13:18:34 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36058 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbdAQSSc (ORCPT ); Tue, 17 Jan 2017 13:18:32 -0500 Date: Tue, 17 Jan 2017 20:10:56 +0200 From: Krzysztof Kozlowski To: Dmitry Torokhov Cc: Krzysztof Kozlowski , Jaechul Lee , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Kukjin Kim , Javier Martinez Canillas , Andi Shyti , Chanwoo Choi , Beomho Seo , =?utf-8?B?7J207J6s7LKg?= , "linux-arm-kernel@lists.infradead.org" , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , lkml , "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 Message-ID: <20170117181056.mrwyudslfgh2wfms@kozik-lap> References: <1484632479-3111-1-git-send-email-jcsing.lee@samsung.com> <1484632479-3111-3-git-send-email-jcsing.lee@samsung.com> <20170117172047.47535bj5xd6toayu@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo > >> Signed-off-by: Jaechul Lee > >> Reviewed-by: Javier Martinez Canillas > >> Reviewed-by: Andi Shyti > >> Reviewed-by: Chanwoo Choi > >> Tested-by: Chanwoo Choi > >> Acked-by: Krzysztof Kozlowski > >> Signed-off-by: Dmitry Torokhov > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 Date: Tue, 17 Jan 2017 20:10:56 +0200 Message-ID: <20170117181056.mrwyudslfgh2wfms@kozik-lap> References: <1484632479-3111-1-git-send-email-jcsing.lee@samsung.com> <1484632479-3111-3-git-send-email-jcsing.lee@samsung.com> <20170117172047.47535bj5xd6toayu@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dmitry Torokhov Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Andi Shyti , Chanwoo Choi , Catalin Marinas , Jaechul Lee , Will Deacon , lkml , Krzysztof Kozlowski , Javier Martinez Canillas , Rob Herring , Kukjin Kim , "linux-input@vger.kernel.org" , =?utf-8?B?7J207J6s7LKg?= , Beomho Seo , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo > >> Signed-off-by: Jaechul Lee > >> Reviewed-by: Javier Martinez Canillas > >> Reviewed-by: Andi Shyti > >> Reviewed-by: Chanwoo Choi > >> Tested-by: Chanwoo Choi > >> Acked-by: Krzysztof Kozlowski > >> Signed-off-by: Dmitry Torokhov > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: krzk@kernel.org (Krzysztof Kozlowski) Date: Tue, 17 Jan 2017 20:10:56 +0200 Subject: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 In-Reply-To: References: <1484632479-3111-1-git-send-email-jcsing.lee@samsung.com> <1484632479-3111-3-git-send-email-jcsing.lee@samsung.com> <20170117172047.47535bj5xd6toayu@kozik-lap> Message-ID: <20170117181056.mrwyudslfgh2wfms@kozik-lap> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski wrote: > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > >> This patch adds support for the TM2 touch key and led > >> functionality. > >> > >> The driver interfaces with userspace through an input device and > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > >> > >> Signed-off-by: Beomho Seo > >> Signed-off-by: Jaechul Lee > >> Reviewed-by: Javier Martinez Canillas > >> Reviewed-by: Andi Shyti > >> Reviewed-by: Chanwoo Choi > >> Tested-by: Chanwoo Choi > >> Acked-by: Krzysztof Kozlowski > >> Signed-off-by: Dmitry Torokhov > > > > This looks unusual. How did Dmitry's Sob end here? > > I sent Jaechul a version of the patch to try out. Ah, makes sense then. Best regards, Krzysztof