From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/common: Drop function calls for Xen compile/version information
Date: Tue, 17 Jan 2017 13:42:54 -0500 [thread overview]
Message-ID: <20170117184254.GU12951@char.us.oracle.com> (raw)
In-Reply-To: <32515ecc-270e-0b5c-490e-ad57e0f8f704@citrix.com>
On Tue, Jan 17, 2017 at 06:16:36PM +0000, Andrew Cooper wrote:
> On 17/01/17 18:05, Konrad Rzeszutek Wilk wrote:
> > On Mon, Jan 16, 2017 at 01:04:09PM +0000, Andrew Cooper wrote:
> >> The chageset/version/compile information is currently exported as a set of
> >> function calls into a separate translation unit, which is inefficient for all
> >> callers.
> >>
> >> Replace the function calls with externs pointing appropriately into .rodata,
> >> which allows all users to generate code referencing the data directly.
> >>
> >> No functional change, but causes smaller and more efficient compiled code.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > Ah crud. That breaks the livepatch test-cases (they patch the xen_extra_version
> > function).
>
> Lucky I haven't pushed it then, (although the livepatch build seems to
> still work fine for me, despite this change.)
make tests should fail.
>
> > Are there some other code that can be modified that is reported
> > by 'xl info' on which the test-cases can run (and reported easily?).
>
> Patch do_version() itself to return the same difference of information?
Ugh. That is going to make the building of test-cases quite complex.
I guess it can just do it and .. return only one value :-)
>
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-17 18:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:04 [PATCH] xen/common: Drop function calls for Xen compile/version information Andrew Cooper
2017-01-16 13:18 ` Jan Beulich
2017-01-16 13:26 ` Andrew Cooper
2017-01-16 18:23 ` Stefano Stabellini
2017-01-16 19:44 ` Doug Goldstein
2017-01-17 18:05 ` Konrad Rzeszutek Wilk
2017-01-17 18:16 ` Andrew Cooper
2017-01-17 18:42 ` Konrad Rzeszutek Wilk [this message]
2017-01-17 19:00 ` Konrad Rzeszutek Wilk
2017-01-17 20:39 ` Andrew Cooper
2017-01-17 20:46 ` Konrad Rzeszutek Wilk
2017-01-18 10:13 ` Roger Pau Monné
2017-01-18 16:10 ` Konrad Rzeszutek Wilk
2017-01-18 16:21 ` Roger Pau Monné
2017-01-18 16:30 ` Wei Liu
2017-01-18 17:04 ` Andrew Cooper
2017-01-18 19:01 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117184254.GU12951@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.