All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emmanuel Vadot <manu@bidouilliste.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] kconfig: Add API kconfig file
Date: Tue, 17 Jan 2017 20:40:56 +0100	[thread overview]
Message-ID: <20170117204056.a2c67e15dc69f3625dcff185@bidouilliste.com> (raw)
In-Reply-To: <1f0d73f9-1180-f9f6-2519-10a4de5ea621@suse.de>


 Hi Andreas,

On Tue, 17 Jan 2017 18:16:58 +0100
Andreas F?rber <afaerber@suse.de> wrote:

> Am 17.01.2017 um 16:50 schrieb Emmanuel Vadot:
> > Add kconfig file to enable API support
> > 
> > Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com>
> > ---
> >  Kconfig     | 2 ++
> >  api/Kconfig | 9 +++++++++
> >  2 files changed, 11 insertions(+)
> >  create mode 100644 api/Kconfig
> > 
> > diff --git a/Kconfig b/Kconfig
> > index 39a4d938d8..6a93d8820f 100644
> > --- a/Kconfig
> > +++ b/Kconfig
> > @@ -306,6 +306,8 @@ config ARCH_FIXUP_FDT_MEMORY
> >  
> >  endmenu		# Boot images
> >  
> > +source "api/Kconfig"
> > +
> >  source "common/Kconfig"
> >  
> >  source "cmd/Kconfig"
> > diff --git a/api/Kconfig b/api/Kconfig
> > new file mode 100644
> > index 0000000000..88b4f6c4e5
> > --- /dev/null
> > +++ b/api/Kconfig
> > @@ -0,0 +1,9 @@
> > +menu "API"
> > +
> > +config API
> > +	bool "Enable U-Boot API"
> > +	default n
> > +	help
> > +	  This option enable the U-Boot API.
> 
> "enables"

 I'll change that, thanks for reviewing.

> Should the help say, e.g., "userspace API" for clarity?

 I don't know, I'm for whatever is best.

> 
> > +
> > +endmenu
> 
> Otherwise looks okay, obviously.
> 
> Regards,
> Andreas
> 
> -- 
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
> GF: Felix Imend?rffer, Jane Smithard, Graham Norton
> HRB 21284 (AG N?rnberg)


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

  reply	other threads:[~2017-01-17 19:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 15:50 [U-Boot] [PATCH v2 0/4] Add FreeBSD kconfig options Emmanuel Vadot
2017-01-17 15:50 ` [U-Boot] [PATCH v2 1/4] kconfig: Add API kconfig file Emmanuel Vadot
2017-01-17 17:16   ` Andreas Färber
2017-01-17 19:40     ` Emmanuel Vadot [this message]
2017-01-17 19:51       ` Warner Losh
2017-01-21  3:51   ` Simon Glass
2017-01-22  4:22     ` Warner Losh
2017-01-23 14:51       ` Tom Rini
2017-01-23 16:05         ` Emmanuel Vadot
2017-01-23 16:22           ` Tom Rini
2017-01-23 12:48     ` Emmanuel Vadot
2017-01-17 15:50 ` [U-Boot] [PATCH v2 2/4] kconfig: Add a FREEBSD option Emmanuel Vadot
2017-01-21  3:51   ` Simon Glass
2017-01-21 10:31     ` Jeroen Hofstee
2017-01-22  4:19     ` Warner Losh
2017-01-17 15:50 ` [U-Boot] [PATCH v2 3/4] api: FreeBSD: flush cache before starting loader/kernel Emmanuel Vadot
2017-01-17 20:13   ` Alexander Graf
2017-01-17 20:45     ` Emmanuel Vadot
2017-01-17 20:58       ` Alexander Graf
2017-01-18 10:42         ` Emmanuel Vadot
2017-01-21  3:51   ` Simon Glass
2017-01-23 12:50     ` Emmanuel Vadot
2017-01-17 15:50 ` [U-Boot] [PATCH v2 4/4] distro_bootcmd: Add command to run FreeBSD Emmanuel Vadot
2017-01-17 20:15   ` Alexander Graf
2017-01-17 19:36 ` [U-Boot] [PATCH v2 0/4] Add FreeBSD kconfig options Alexander Graf
2017-01-17 19:47   ` Emmanuel Vadot
2017-01-17 19:57     ` Warner Losh
2017-01-17 20:11       ` Alexander Graf
     [not found] ` <f07ec2834278bb372fb456338f2af313@agner.ch>
2017-01-17 19:41   ` Emmanuel Vadot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170117204056.a2c67e15dc69f3625dcff185@bidouilliste.com \
    --to=manu@bidouilliste.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.