From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751081AbdAQTSK (ORCPT ); Tue, 17 Jan 2017 14:18:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51100 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750939AbdAQTSH (ORCPT ); Tue, 17 Jan 2017 14:18:07 -0500 Date: Tue, 17 Jan 2017 21:11:26 +0200 From: "Michael S. Tsirkin" To: "Li, Liang Z" Cc: "kvm@vger.kernel.org" , "virtio-dev@lists.oasis-open.org" , "qemu-devel@nongnu.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "amit.shah@redhat.com" , "Hansen, Dave" , "cornelia.huck@de.ibm.com" , "pbonzini@redhat.com" , "david@redhat.com" , "aarcange@redhat.com" , "dgilbert@redhat.com" , "quintela@redhat.com" Subject: Re: [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct Message-ID: <20170117210845-mutt-send-email-mst@kernel.org> References: <1482303148-22059-1-git-send-email-liang.z.li@intel.com> <1482303148-22059-3-git-send-email-liang.z.li@intel.com> <20170112185719-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 17 Jan 2017 19:11:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 13, 2017 at 09:24:22AM +0000, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using ranges can improve the performance of > > > inflating/deflating significantly. > > > > > > Signed-off-by: Liang Li > > > Cc: Michael S. Tsirkin > > > Cc: Paolo Bonzini > > > Cc: Cornelia Huck > > > Cc: Amit Shah > > > Cc: Dave Hansen > > > Cc: Andrea Arcangeli > > > Cc: David Hildenbrand > > > --- > > > include/uapi/linux/virtio_balloon.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_balloon.h > > > b/include/uapi/linux/virtio_balloon.h > > > index 343d7dd..2f850bf 100644 > > > --- a/include/uapi/linux/virtio_balloon.h > > > +++ b/include/uapi/linux/virtio_balloon.h > > > @@ -34,10 +34,14 @@ > > > #define VIRTIO_BALLOON_F_MUST_TELL_HOST 0 /* Tell before > > reclaiming pages */ > > > #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue > > */ > > > #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon > > on OOM */ > > > +#define VIRTIO_BALLOON_F_PAGE_RANGE 3 /* Send page info > > with ranges */ > > > > > > /* Size of a PFN in the balloon interface. */ #define > > > VIRTIO_BALLOON_PFN_SHIFT 12 > > > > > > +/* Bits width for the length of the pfn range */ > > > > What does this mean? Couldn't figure it out. > > > > > +#define VIRTIO_BALLOON_NR_PFN_BITS 12 > > > + > > > struct virtio_balloon_config { > > > /* Number of pages host wants Guest to give up. */ > > > __u32 num_pages; > > > @@ -82,4 +86,12 @@ struct virtio_balloon_stat { > > > __virtio64 val; > > > } __attribute__((packed)); > > > > > > +/* Response header structure */ > > > +struct virtio_balloon_resp_hdr { > > > + __le64 cmd : 8; /* Distinguish different requests type */ > > > + __le64 flag: 8; /* Mark status for a specific request type */ > > > + __le64 id : 16; /* Distinguish requests of a specific type */ > > > + __le64 data_len: 32; /* Length of the following data, in bytes */ > > > > This use of __le64 makes no sense. Just use u8/le16/le32 pls. > > > > Got it, will change in the next version. > > And could help take a look at other parts? as well as the QEMU part. > > Thanks! > Liang Yes but first I would like to understand how come no fields in this new structure come up if I search for them in the following patch. I don't see why should I waste time on reviewing the implementation if the interface isn't reasonable. You don't have to waste it too - just send RFC patches with the header until we can agree on it. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct Date: Tue, 17 Jan 2017 21:11:26 +0200 Message-ID: <20170117210845-mutt-send-email-mst@kernel.org> References: <1482303148-22059-1-git-send-email-liang.z.li@intel.com> <1482303148-22059-3-git-send-email-liang.z.li@intel.com> <20170112185719-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "kvm@vger.kernel.org" , "virtio-dev@lists.oasis-open.org" , "qemu-devel@nongnu.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "amit.shah@redhat.com" , "Hansen, Dave" , "cornelia.huck@de.ibm.com" , "pbonzini@redhat.com" , "david@redhat.com" , "aarcange@redhat.com" , "dgilbert@redhat.com" , "quintela@redhat.com" To: "Li, Liang Z" Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org On Fri, Jan 13, 2017 at 09:24:22AM +0000, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using ranges can improve the performance of > > > inflating/deflating significantly. > > > > > > Signed-off-by: Liang Li > > > Cc: Michael S. Tsirkin > > > Cc: Paolo Bonzini > > > Cc: Cornelia Huck > > > Cc: Amit Shah > > > Cc: Dave Hansen > > > Cc: Andrea Arcangeli > > > Cc: David Hildenbrand > > > --- > > > include/uapi/linux/virtio_balloon.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_balloon.h > > > b/include/uapi/linux/virtio_balloon.h > > > index 343d7dd..2f850bf 100644 > > > --- a/include/uapi/linux/virtio_balloon.h > > > +++ b/include/uapi/linux/virtio_balloon.h > > > @@ -34,10 +34,14 @@ > > > #define VIRTIO_BALLOON_F_MUST_TELL_HOST 0 /* Tell before > > reclaiming pages */ > > > #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue > > */ > > > #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon > > on OOM */ > > > +#define VIRTIO_BALLOON_F_PAGE_RANGE 3 /* Send page info > > with ranges */ > > > > > > /* Size of a PFN in the balloon interface. */ #define > > > VIRTIO_BALLOON_PFN_SHIFT 12 > > > > > > +/* Bits width for the length of the pfn range */ > > > > What does this mean? Couldn't figure it out. > > > > > +#define VIRTIO_BALLOON_NR_PFN_BITS 12 > > > + > > > struct virtio_balloon_config { > > > /* Number of pages host wants Guest to give up. */ > > > __u32 num_pages; > > > @@ -82,4 +86,12 @@ struct virtio_balloon_stat { > > > __virtio64 val; > > > } __attribute__((packed)); > > > > > > +/* Response header structure */ > > > +struct virtio_balloon_resp_hdr { > > > + __le64 cmd : 8; /* Distinguish different requests type */ > > > + __le64 flag: 8; /* Mark status for a specific request type */ > > > + __le64 id : 16; /* Distinguish requests of a specific type */ > > > + __le64 data_len: 32; /* Length of the following data, in bytes */ > > > > This use of __le64 makes no sense. Just use u8/le16/le32 pls. > > > > Got it, will change in the next version. > > And could help take a look at other parts? as well as the QEMU part. > > Thanks! > Liang Yes but first I would like to understand how come no fields in this new structure come up if I search for them in the following patch. I don't see why should I waste time on reviewing the implementation if the interface isn't reasonable. You don't have to waste it too - just send RFC patches with the header until we can agree on it. -- MST -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTZAK-0007KE-KG for qemu-devel@nongnu.org; Tue, 17 Jan 2017 14:11:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTZAH-0007GE-Fj for qemu-devel@nongnu.org; Tue, 17 Jan 2017 14:11:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34512) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTZAH-0007Fm-7B for qemu-devel@nongnu.org; Tue, 17 Jan 2017 14:11:29 -0500 Date: Tue, 17 Jan 2017 21:11:26 +0200 From: "Michael S. Tsirkin" Message-ID: <20170117210845-mutt-send-email-mst@kernel.org> References: <1482303148-22059-1-git-send-email-liang.z.li@intel.com> <1482303148-22059-3-git-send-email-liang.z.li@intel.com> <20170112185719-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Liang Z" Cc: "kvm@vger.kernel.org" , "virtio-dev@lists.oasis-open.org" , "qemu-devel@nongnu.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "amit.shah@redhat.com" , "Hansen, Dave" , "cornelia.huck@de.ibm.com" , "pbonzini@redhat.com" , "david@redhat.com" , "aarcange@redhat.com" , "dgilbert@redhat.com" , "quintela@redhat.com" On Fri, Jan 13, 2017 at 09:24:22AM +0000, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using ranges can improve the performance of > > > inflating/deflating significantly. > > > > > > Signed-off-by: Liang Li > > > Cc: Michael S. Tsirkin > > > Cc: Paolo Bonzini > > > Cc: Cornelia Huck > > > Cc: Amit Shah > > > Cc: Dave Hansen > > > Cc: Andrea Arcangeli > > > Cc: David Hildenbrand > > > --- > > > include/uapi/linux/virtio_balloon.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_balloon.h > > > b/include/uapi/linux/virtio_balloon.h > > > index 343d7dd..2f850bf 100644 > > > --- a/include/uapi/linux/virtio_balloon.h > > > +++ b/include/uapi/linux/virtio_balloon.h > > > @@ -34,10 +34,14 @@ > > > #define VIRTIO_BALLOON_F_MUST_TELL_HOST 0 /* Tell before > > reclaiming pages */ > > > #define VIRTIO_BALLOON_F_STATS_VQ 1 /* Memory Stats virtqueue > > */ > > > #define VIRTIO_BALLOON_F_DEFLATE_ON_OOM 2 /* Deflate balloon > > on OOM */ > > > +#define VIRTIO_BALLOON_F_PAGE_RANGE 3 /* Send page info > > with ranges */ > > > > > > /* Size of a PFN in the balloon interface. */ #define > > > VIRTIO_BALLOON_PFN_SHIFT 12 > > > > > > +/* Bits width for the length of the pfn range */ > > > > What does this mean? Couldn't figure it out. > > > > > +#define VIRTIO_BALLOON_NR_PFN_BITS 12 > > > + > > > struct virtio_balloon_config { > > > /* Number of pages host wants Guest to give up. */ > > > __u32 num_pages; > > > @@ -82,4 +86,12 @@ struct virtio_balloon_stat { > > > __virtio64 val; > > > } __attribute__((packed)); > > > > > > +/* Response header structure */ > > > +struct virtio_balloon_resp_hdr { > > > + __le64 cmd : 8; /* Distinguish different requests type */ > > > + __le64 flag: 8; /* Mark status for a specific request type */ > > > + __le64 id : 16; /* Distinguish requests of a specific type */ > > > + __le64 data_len: 32; /* Length of the following data, in bytes */ > > > > This use of __le64 makes no sense. Just use u8/le16/le32 pls. > > > > Got it, will change in the next version. > > And could help take a look at other parts? as well as the QEMU part. > > Thanks! > Liang Yes but first I would like to understand how come no fields in this new structure come up if I search for them in the following patch. I don't see why should I waste time on reviewing the implementation if the interface isn't reasonable. You don't have to waste it too - just send RFC patches with the header until we can agree on it. -- MST