From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mingo@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: fix iret's opcode
Date: Wed, 18 Jan 2017 10:17:08 -0600 [thread overview]
Message-ID: <20170118161708.jojbccphpfzowy54@treble> (raw)
In-Reply-To: <20170118132921.19319-1-jslaby@suse.cz>
On Wed, Jan 18, 2017 at 02:29:21PM +0100, Jiri Slaby wrote:
> iret is 0xcf according to the Intel manual and also to objdump of my
> vmlinux:
> 1ea8: 48 cf iretq
>
> Fix the opcode in arch_decode_instruction.
>
> The previous value (0xc5) seems to correspond to lds.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
Thanks!
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/objtool/arch/x86/decode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
> index 5e0dea2cdc01..039636ffb6c8 100644
> --- a/tools/objtool/arch/x86/decode.c
> +++ b/tools/objtool/arch/x86/decode.c
> @@ -150,9 +150,9 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
> *type = INSN_RETURN;
> break;
>
> - case 0xc5: /* iret */
> case 0xca: /* retf */
> case 0xcb: /* retf */
> + case 0xcf: /* iret */
> *type = INSN_CONTEXT_SWITCH;
> break;
>
> --
> 2.11.0
>
--
Josh
next prev parent reply other threads:[~2017-01-18 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 13:29 [PATCH] objtool: fix iret's opcode Jiri Slaby
2017-01-18 16:17 ` Josh Poimboeuf [this message]
2017-01-19 9:10 ` [tip:core/urgent] objtool: Fix IRET's opcode tip-bot for Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118161708.jojbccphpfzowy54@treble \
--to=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.