From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v4 3/4] dt-bindings: phy: Add support for QMP phy Date: Wed, 18 Jan 2017 10:22:23 -0800 Message-ID: <20170118182223.GP10531@minitux> References: <1484045519-19030-1-git-send-email-vivek.gautam@codeaurora.org> <1484045519-19030-4-git-send-email-vivek.gautam@codeaurora.org> <587C88FE.2040900@ti.com> <50612693-5345-55da-8207-8c5e721fb68a@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <50612693-5345-55da-8207-8c5e721fb68a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vivek Gautam Cc: Kishon Vijay Abraham I , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Tue 17 Jan 22:54 PST 2017, Vivek Gautam wrote: > On 01/16/2017 02:19 PM, Kishon Vijay Abraham I wrote: > > On Tuesday 10 January 2017 04:21 PM, Vivek Gautam wrote: [..] > > > + reset-names = "phy", "common", "cfg", > > > + "lane0", "lane1", "lane2"; > > Each lane has a separate clock, separate reset.. why not create sub-nodes for > > each lane? > > Yes, each lane has separate pipe clock and resets. > I can have a binding such as written below. +1 > Does it makes sense to pull in the tx, rx and pcs offsets as well > to the child node, and iomap the entire address space of the phy ? > Note that you don't have to follow the same structure in your device driver as you describe your hardware in devicetree. I would suggest that you replace the lane-offset and various lane specific resources with subnodes, but keep the driver "as is". Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832AbdARSWa (ORCPT ); Wed, 18 Jan 2017 13:22:30 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33865 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbdARSW1 (ORCPT ); Wed, 18 Jan 2017 13:22:27 -0500 Date: Wed, 18 Jan 2017 10:22:23 -0800 From: Bjorn Andersson To: Vivek Gautam Cc: Kishon Vijay Abraham I , robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, sboyd@codeaurora.org, srinivas.kandagatla@linaro.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 3/4] dt-bindings: phy: Add support for QMP phy Message-ID: <20170118182223.GP10531@minitux> References: <1484045519-19030-1-git-send-email-vivek.gautam@codeaurora.org> <1484045519-19030-4-git-send-email-vivek.gautam@codeaurora.org> <587C88FE.2040900@ti.com> <50612693-5345-55da-8207-8c5e721fb68a@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50612693-5345-55da-8207-8c5e721fb68a@codeaurora.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17 Jan 22:54 PST 2017, Vivek Gautam wrote: > On 01/16/2017 02:19 PM, Kishon Vijay Abraham I wrote: > > On Tuesday 10 January 2017 04:21 PM, Vivek Gautam wrote: [..] > > > + reset-names = "phy", "common", "cfg", > > > + "lane0", "lane1", "lane2"; > > Each lane has a separate clock, separate reset.. why not create sub-nodes for > > each lane? > > Yes, each lane has separate pipe clock and resets. > I can have a binding such as written below. +1 > Does it makes sense to pull in the tx, rx and pcs offsets as well > to the child node, and iomap the entire address space of the phy ? > Note that you don't have to follow the same structure in your device driver as you describe your hardware in devicetree. I would suggest that you replace the lane-offset and various lane specific resources with subnodes, but keep the driver "as is". Regards, Bjorn