From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbdARVek (ORCPT ); Wed, 18 Jan 2017 16:34:40 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35586 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdARVed (ORCPT ); Wed, 18 Jan 2017 16:34:33 -0500 Date: Wed, 18 Jan 2017 15:34:02 -0600 From: Rob Herring To: Yong Mao Cc: Ulf Hansson , Mark Rutland , Matthias Brugger , Catalin Marinas , Will Deacon , Chaotian Jing , Philipp Zabel , Greg Kroah-Hartman , Eddie Huang , Chunfeng Yun , Nicolas Boichat , Douglas Anderson , Javier Martinez Canillas , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com Subject: Re: [PATCH 2/2] mmc: dt-bindings: update Mediatek MMC bindings Message-ID: <20170118213402.rbduvubbsdpvfgad@rob-hp-laptop> References: <1484215490-7494-1-git-send-email-yong.mao@mediatek.com> <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 06:04:50PM +0800, Yong Mao wrote: > From: yong mao > > Add description for hs200-cmd-int-delay > Add description for hs400-cmd-int-delay > Add description for cmd-resp-sel > > Signed-off-by: Yong Mao > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..2dbb3b0 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,9 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- hs200-cmd-int-delay: HS200 command internal delay setting > +- hs400-cmd-int-delay: HS400 command internal delay setting What are the units and range of values? These need vendor prefix as well. > +- cmd-resp-sel: command response sample selection Looks like a boolean. State that and make the default the more common case. > > Examples: > mmc0: mmc@11230000 { > @@ -38,4 +41,7 @@ mmc0: mmc@11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + hs200-cmd-int-delay = <26>; > + hs400-cmd-int-delay = <14>; > + cmd-resp-sel = <0>; /* 0: rising, 1: falling */ > }; > -- > 1.7.9.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 2/2] mmc: dt-bindings: update Mediatek MMC bindings Date: Wed, 18 Jan 2017 15:34:02 -0600 Message-ID: <20170118213402.rbduvubbsdpvfgad@rob-hp-laptop> References: <1484215490-7494-1-git-send-email-yong.mao@mediatek.com> <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yong Mao Cc: Mark Rutland , devicetree@vger.kernel.org, Ulf Hansson , Nicolas Boichat , srv_heupstream@mediatek.com, Javier Martinez Canillas , Catalin Marinas , Will Deacon , Douglas Anderson , linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Philipp Zabel , Greg Kroah-Hartman , Matthias Brugger , linux-mmc@vger.kernel.org, Eddie Huang , Chaotian Jing List-Id: devicetree@vger.kernel.org On Thu, Jan 12, 2017 at 06:04:50PM +0800, Yong Mao wrote: > From: yong mao > > Add description for hs200-cmd-int-delay > Add description for hs400-cmd-int-delay > Add description for cmd-resp-sel > > Signed-off-by: Yong Mao > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..2dbb3b0 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,9 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- hs200-cmd-int-delay: HS200 command internal delay setting > +- hs400-cmd-int-delay: HS400 command internal delay setting What are the units and range of values? These need vendor prefix as well. > +- cmd-resp-sel: command response sample selection Looks like a boolean. State that and make the default the more common case. > > Examples: > mmc0: mmc@11230000 { > @@ -38,4 +41,7 @@ mmc0: mmc@11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + hs200-cmd-int-delay = <26>; > + hs400-cmd-int-delay = <14>; > + cmd-resp-sel = <0>; /* 0: rising, 1: falling */ > }; > -- > 1.7.9.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Wed, 18 Jan 2017 15:34:02 -0600 Subject: [PATCH 2/2] mmc: dt-bindings: update Mediatek MMC bindings In-Reply-To: <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> References: <1484215490-7494-1-git-send-email-yong.mao@mediatek.com> <1484215490-7494-3-git-send-email-yong.mao@mediatek.com> Message-ID: <20170118213402.rbduvubbsdpvfgad@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 12, 2017 at 06:04:50PM +0800, Yong Mao wrote: > From: yong mao > > Add description for hs200-cmd-int-delay > Add description for hs400-cmd-int-delay > Add description for cmd-resp-sel > > Signed-off-by: Yong Mao > --- > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > index 0120c7f..2dbb3b0 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt > @@ -21,6 +21,9 @@ Optional properties: > - assigned-clocks: PLL of the source clock > - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock > - hs400-ds-delay: HS400 DS delay setting > +- hs200-cmd-int-delay: HS200 command internal delay setting > +- hs400-cmd-int-delay: HS400 command internal delay setting What are the units and range of values? These need vendor prefix as well. > +- cmd-resp-sel: command response sample selection Looks like a boolean. State that and make the default the more common case. > > Examples: > mmc0: mmc at 11230000 { > @@ -38,4 +41,7 @@ mmc0: mmc at 11230000 { > assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>; > assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>; > hs400-ds-delay = <0x14015>; > + hs200-cmd-int-delay = <26>; > + hs400-cmd-int-delay = <14>; > + cmd-resp-sel = <0>; /* 0: rising, 1: falling */ > }; > -- > 1.7.9.5 >