From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 2/5] perf, tools: Add one liner warning for disabled features
Date: Wed, 18 Jan 2017 17:41:47 -0800 [thread overview]
Message-ID: <20170119014150.19218-3-andi@firstfloor.org> (raw)
In-Reply-To: <20170119014150.19218-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.
Currently enabled for XED and BABELTRACE.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/Makefile.config | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 9996027e7a52..39b90ffd9412 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
NO_LIBDW_DWARF_UNWIND := 1
endif
+DISABLED_FEATURES =
+
ifeq ($(LIBUNWIND_LIBS),)
NO_LIBUNWIND := 1
endif
@@ -698,6 +700,8 @@ ifdef XED
EXTLIBS += -lxed
$(call detected,CONFIG_XED)
endif
+else
+ DISABLED_FEATURES += XED
endif
ifndef NO_LZMA
@@ -772,6 +776,8 @@ ifdef LIBBABELTRACE
else
msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
endif
+else
+ DISABLED_FEATURES += LIBBABELTRACE
endif
ifndef NO_AUXTRACE
@@ -843,6 +849,10 @@ ifdef LIBCLANGLLVM
endif
endif
+ifneq ($(DISABLED_FEATURES),)
+ $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
# Among the variables below, these:
# perfexecdir
# template_dir
--
2.9.3
next prev parent reply other threads:[~2017-01-19 1:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 1:41 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-19 1:41 ` Andi Kleen [this message]
2017-01-19 1:41 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-19 1:41 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-23 19:49 ` Arnaldo Carvalho de Melo
2017-01-23 19:55 ` Andi Kleen
2017-01-23 20:06 ` Arnaldo Carvalho de Melo
2017-01-19 1:41 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-24 18:54 ` Arnaldo Carvalho de Melo
2017-01-19 15:36 ` New attempt at adding an disassembler to perf Jiri Olsa
2017-01-19 16:54 ` Andi Kleen
2017-01-20 13:22 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-01-10 1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10 1:02 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
2017-01-11 18:41 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119014150.19218-3-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.