From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] devtools: check stable tag in fixes Date: Thu, 19 Jan 2017 16:05:06 +0800 Message-ID: <20170119080506.GT10293@yliu-dev.sh.intel.com> References: <1484664872-26859-1-git-send-email-thomas.monjalon@6wind.com> <1860075.ojoIIAvjcn@xps13> <20170118044150.GN10293@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , dev@dpdk.org, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com To: Ferruh Yigit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 43F66FB4E for ; Thu, 19 Jan 2017 09:02:57 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jan 18, 2017 at 05:25:10PM +0000, Ferruh Yigit wrote: > On 1/18/2017 4:41 AM, Yuanhan Liu wrote: > > On Tue, Jan 17, 2017 at 07:42:33PM +0100, Thomas Monjalon wrote: > >> 2017-01-17 18:15, Ferruh Yigit: > >>> On 1/17/2017 2:54 PM, Thomas Monjalon wrote: > >>>> The tag "Cc: stable@dpdk.org" must be set when the commit must be > >>>> backported to a stable branch. > >>>> > >>>> It must be located just below the "Fixes:" tag (without blank line) > >>>> and followed by a blank line, separated from SoB and review tags below. > >>> > >>> I am OK to keep it if it will help stable tree maintenance, but I still > >>> not clear about why we need this. > >>> > >>> If a patch is a fix, it should already have "Fixes:" line, so this can > >>> be used to parse git history. > > > > Same answer (as I have already replied to you in another email): not all fix > > patches should be picked to stable branch. (I gave some examples below) > > I was thinking all fixes will have "Cc: stable" tag, to be sure all > fixes sent to stable mail list, and you will be the picking for stable tree. > > Now you are suggesting some fixes may have "Fixes:" tag but not "Cc: > stable" tag. > > So this means now author/maintainer/committer will be the picking > patches for stable tree, and to show this decision, will add "Cc: > stable" to the commit log. > > If author puts the "Cc: stable" tag, git send-email will ensure this > patch will be sent to stable mail list too. > But if author missed the "Cc: stable" tag, will it be enough for you if > committer adds the tag into commit log? Or should patch sent to stable > mail list too? Yes, that'd be enough. I will write a short script to monitor the official DPDK git tree regularly (say weekly), to see whether there are any new candidates (those with 'cc: stable' tag) for stable releases or not. If so, I will pick them to stable. > > What is the relation between "Cc: stable" tag been in commit log and > patch been sent to stable mail list? Not too much. The stable mailing list provides a place for further discussion on stable patches: - A notification will be sent to the stable mailing list when a patch is chosen as a candidate for a stable release. People can shout out if he thinks some patches should not have been picked for a stable release. - people can also jump out to say, "hey, seems you forgot commit xxx, which is a good have for stable release". --yliu