From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbdASLp4 (ORCPT ); Thu, 19 Jan 2017 06:45:56 -0500 Received: from mail.skyhub.de ([78.46.96.112]:58626 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbdASLpy (ORCPT ); Thu, 19 Jan 2017 06:45:54 -0500 Date: Thu, 19 Jan 2017 12:23:01 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: X86 ML , One Thousand Gnomes , "linux-kernel@vger.kernel.org" , Brian Gerst , Matthew Whitehead Subject: Re: [PATCH v2 3/6] x86/cpu: Re-apply forced caps every time cpu caps are re-read Message-ID: <20170119112301.fop6boxbpyk3tf4a@pd.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 18, 2017 at 11:15:39AM -0800, Andy Lutomirski wrote: > Calling get_cpu_cap() will reset a bunch of CPU features. This will > cause the system to lose track of force-set and force-cleared > featueres in the words that are reset until the end of CPU features > initialization. This can cause X86_FEATURE_FPU, for example, to > change back and forth during boot and potentially confuse CPU setup. > > To minimize the chance of confusion, re-apply forced caps every time > get_cpu_cap() is called. > > Signed-off-by: Andy Lutomirski -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.