From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [arm:phy-cleanup 10/10] arch/mips/cavium-octeon/octeon-platform.c:1064:15: error: expected declaration specifiers or '...' before string constant
Date: Thu, 19 Jan 2017 13:54:52 +0000 [thread overview]
Message-ID: <20170119135452.GY27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <201701192138.NZ3q3lNY%fengguang.wu@intel.com>
Hi David,
Is there a reason why there's these MODULE_* macros at the bottom of
this file? From what I can see:
(a) this file can't be built as a module as the Makefile doesn't allow it:
obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o
(b) this file will not be functional as a module anyway, because of the
multiple *_initcall() statements, each of which are translated to
a module_init() call, each of which define an alias to
int init_module(void) - and that will cause a build error.
Can we just kill these, rather than adding a linux/module.h include to
this file?
Thanks.
On Thu, Jan 19, 2017 at 09:08:42PM +0800, kbuild test robot wrote:
> tree: git://git.armlinux.org.uk/~rmk/linux-arm.git phy-cleanup
> head: ef8cb7d5f838770f22cae0e20fee8d1157fc88fd
> commit: ef8cb7d5f838770f22cae0e20fee8d1157fc88fd [10/10] net: dsa: remove unnecessary phy*.h includes
> config: mips-cavium_octeon_defconfig (attached as .config)
> compiler: mips64-linux-gnuabi64-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout ef8cb7d5f838770f22cae0e20fee8d1157fc88fd
> # save the attached .config to linux build tree
> make.cross ARCH=mips
>
> All errors (new ones prefixed by >>):
>
> >> arch/mips/cavium-octeon/octeon-platform.c:1064:15: error: expected declaration specifiers or '...' before string constant
> MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/mips/cavium-octeon/octeon-platform.c:1065:16: error: expected declaration specifiers or '...' before string constant
> MODULE_LICENSE("GPL");
> ^~~~~
> arch/mips/cavium-octeon/octeon-platform.c:1066:20: error: expected declaration specifiers or '...' before string constant
> MODULE_DESCRIPTION("Platform driver for Octeon SOC");
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> vim +1064 arch/mips/cavium-octeon/octeon-platform.c
>
> d617f9e9 David Daney 2013-12-03 1048 break;
> d617f9e9 David Daney 2013-12-03 1049 default:
> d617f9e9 David Daney 2013-12-03 1050 break;
> d617f9e9 David Daney 2013-12-03 1051 }
> d617f9e9 David Daney 2013-12-03 1052 }
> d617f9e9 David Daney 2013-12-03 1053 }
> d617f9e9 David Daney 2013-12-03 1054
> 7ed18152 David Daney 2012-07-05 1055 return 0;
> 7ed18152 David Daney 2012-07-05 1056 }
> 7ed18152 David Daney 2012-07-05 1057
> 7ed18152 David Daney 2012-07-05 1058 static int __init octeon_publish_devices(void)
> 7ed18152 David Daney 2012-07-05 1059 {
> 7ed18152 David Daney 2012-07-05 1060 return of_platform_bus_probe(NULL, octeon_ids, NULL);
> 7ed18152 David Daney 2012-07-05 1061 }
> 8074d782 Aaro Koskinen 2016-08-23 1062 arch_initcall(octeon_publish_devices);
> 7ed18152 David Daney 2012-07-05 1063
> 512254ba David Daney 2009-09-16 @1064 MODULE_AUTHOR("David Daney <ddaney@caviumnetworks.com>");
> 512254ba David Daney 2009-09-16 1065 MODULE_LICENSE("GPL");
> 512254ba David Daney 2009-09-16 1066 MODULE_DESCRIPTION("Platform driver for Octeon SOC");
>
> :::::: The code at line 1064 was first introduced by commit
> :::::: 512254ba8383c5dd7eca6819d0da1ce2fe9ede47 MIPS: Octeon: Move some platform device registration to its own file.
>
> :::::: TO: David Daney <ddaney@caviumnetworks.com>
> :::::: CC: Ralf Baechle <ralf@linux-mips.org>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-01-19 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 13:08 [arm:phy-cleanup 10/10] arch/mips/cavium-octeon/octeon-platform.c:1064:15: error: expected declaration specifiers or '...' before string constant kbuild test robot
2017-01-19 13:54 ` Russell King - ARM Linux [this message]
2017-01-19 17:11 ` David Daney
2017-01-19 17:11 ` David Daney
2017-01-19 17:11 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119135452.GY27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.