From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153AbdASRhE (ORCPT ); Thu, 19 Jan 2017 12:37:04 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34938 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944AbdASRhB (ORCPT ); Thu, 19 Jan 2017 12:37:01 -0500 Date: Thu, 19 Jan 2017 11:36:59 -0600 From: Rob Herring To: Raviteja Garimella Cc: Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org Subject: Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Message-ID: <20170119173659.jeao5pqtlepmidek@rob-hp-laptop> References: <1484640308-25976-1-git-send-email-raviteja.garimella@broadcom.com> <1484640308-25976-5-git-send-email-raviteja.garimella@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484640308-25976-5-git-send-email-raviteja.garimella@broadcom.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: > This patch adds device tree bindings documentation for Synopsys > USB device controller platform driver. Bindings describe h/w, not drivers. > > Signed-off-by: Raviteja Garimella > --- > .../devicetree/bindings/usb/snps,dw-ahb-udc.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > new file mode 100644 > index 0000000..0c18327 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > @@ -0,0 +1,27 @@ > +Synopsys USB Device controller. > + > +The device node is used for Synopsys Designware Cores AHB > +Subsystem Device Controller (UDC). > + > +This device node is used by UDCs integrated it Broadcom's > +Northstar2 and Cygnus SoC's. You need compatible strings for these in addition. > + > +Required properties: > + - compatible: should be "snps,dw-ahb-udc" This is a different IP than DWC2? > + - reg: Offset and length of UDC register set > + - interrupts: description of interrupt line > + - phys: phandle to phy node. > + - extcon: phandle to the extcon device. This is optional and > + not required for those that don't require extcon support. > + Extcon support will be required if the UDC is connected to > + a Dual Role Device Phy that supports both Host and Device > + mode based on the external cable. Drop this. It should be a part of the phy. Also, I don't care to see new users of extcon binding because it needs redoing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Date: Thu, 19 Jan 2017 11:36:59 -0600 Message-ID: <20170119173659.jeao5pqtlepmidek@rob-hp-laptop> References: <1484640308-25976-1-git-send-email-raviteja.garimella@broadcom.com> <1484640308-25976-5-git-send-email-raviteja.garimella@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1484640308-25976-5-git-send-email-raviteja.garimella-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Raviteja Garimella Cc: Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: > This patch adds device tree bindings documentation for Synopsys > USB device controller platform driver. Bindings describe h/w, not drivers. > > Signed-off-by: Raviteja Garimella > --- > .../devicetree/bindings/usb/snps,dw-ahb-udc.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > new file mode 100644 > index 0000000..0c18327 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt > @@ -0,0 +1,27 @@ > +Synopsys USB Device controller. > + > +The device node is used for Synopsys Designware Cores AHB > +Subsystem Device Controller (UDC). > + > +This device node is used by UDCs integrated it Broadcom's > +Northstar2 and Cygnus SoC's. You need compatible strings for these in addition. > + > +Required properties: > + - compatible: should be "snps,dw-ahb-udc" This is a different IP than DWC2? > + - reg: Offset and length of UDC register set > + - interrupts: description of interrupt line > + - phys: phandle to phy node. > + - extcon: phandle to the extcon device. This is optional and > + not required for those that don't require extcon support. > + Extcon support will be required if the UDC is connected to > + a Dual Role Device Phy that supports both Host and Device > + mode based on the external cable. Drop this. It should be a part of the phy. Also, I don't care to see new users of extcon binding because it needs redoing. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html