From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs
Date: Thu, 19 Jan 2017 22:35:09 +0200 [thread overview]
Message-ID: <20170119203509.4uoh45kwthi7o3wb@kozik-lap> (raw)
In-Reply-To: <1484834310-21173-1-git-send-email-m.szyprowski@samsung.com>
On Thu, Jan 19, 2017 at 02:58:30PM +0100, Marek Szyprowski wrote:
> Common definition for I2S0 bus should not define any pull control for
> the individual I2S pins. Correct this by changing samsung,pin-pud property
> to EXYNOS_PIN_PULL_NONE like it is used for other Exynos SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Makes sense. Two questions here:
1. The same for pcm0_bus?
2. This will affect the specific boards: TM2s. Do they need pull down or
in fact you wanted to fix them as well? Usage of words "common
definition" suggests the board might be different and in fact you are
changing the board now.
Best regards,
Krzysztof
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
> index d49879bd34bb..2171ff965212 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi
> @@ -135,7 +135,7 @@
> samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3",
> "gpz0-4", "gpz0-5", "gpz0-6";
> samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> - samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> samsung,pin-drv = <EXYNOS5433_PIN_DRV_FAST_SR1>;
> };
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-01-19 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170119135856eucas1p149239f274848d61b9aa785e8497d957a@eucas1p1.samsung.com>
2017-01-19 13:58 ` [PATCH] arm64: dts: exynos: Fix i2s0 pins pull control for Exynos5433 SoCs Marek Szyprowski
2017-01-19 15:18 ` Javier Martinez Canillas
2017-01-19 20:35 ` Krzysztof Kozlowski [this message]
2017-01-20 6:51 ` Marek Szyprowski
2017-01-20 15:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119203509.4uoh45kwthi7o3wb@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.