From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdATJbk (ORCPT ); Fri, 20 Jan 2017 04:31:40 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:19633 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdATJbi (ORCPT ); Fri, 20 Jan 2017 04:31:38 -0500 Date: Fri, 20 Jan 2017 12:31:16 +0300 From: Dan Carpenter To: Cathy Avery Cc: kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Message-ID: <20170120093116.GH4398@mwanda> References: <1484771338-8903-1-git-send-email-cavery@redhat.com> <1484771338-8903-3-git-send-email-cavery@redhat.com> <20170118231555.GC4454@mwanda> <5880FD8F.8020608@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5880FD8F.8020608@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote: > > > On 01/18/2017 06:15 PM, Dan Carpenter wrote: > >On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: > >>Enable FC lightweight host option so that the luns exposed by > >>the driver may be manually scanned. > >> > >>Signed-off-by: Cathy Avery > >>--- > >> drivers/scsi/storvsc_drv.c | 6 +----- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >>diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > >>index 888e16e..fc1d6ba 100644 > >>--- a/drivers/scsi/storvsc_drv.c > >>+++ b/drivers/scsi/storvsc_drv.c > >>@@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { > >> static struct fc_function_template fc_transport_functions = { > >> .show_host_node_name = 1, > >> .show_host_port_name = 1, > >>+ .lightweight_transport = 1, > >> }; > >> #endif > >>@@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) > >> fc_transport_template = fc_attach_transport(&fc_transport_functions); > >> if (!fc_transport_template) > >> return -ENODEV; > >>- > >>- /* > >>- * Install Hyper-V specific timeout handler. > >>- */ > >>- fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > >I don't undestand how removing this is related. > > Its not related but it is also not necessary so I took it out. The > default scsi timeout handler will be used. > > I can certainly put it back. I'm not sure that we understand each other properly. Has this patch already been committed? If so, then there is no need to put it back. But it if hasn't been committed, can you resend the patches with that bit broken out into a separate patch with its own changelog? Patches should only do one thing but you're saying that it's doing two unrelated things. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Date: Fri, 20 Jan 2017 12:31:16 +0300 Message-ID: <20170120093116.GH4398@mwanda> References: <1484771338-8903-1-git-send-email-cavery@redhat.com> <1484771338-8903-3-git-send-email-cavery@redhat.com> <20170118231555.GC4454@mwanda> <5880FD8F.8020608@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5880FD8F.8020608@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Cathy Avery Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org List-Id: linux-scsi@vger.kernel.org On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote: > > > On 01/18/2017 06:15 PM, Dan Carpenter wrote: > >On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: > >>Enable FC lightweight host option so that the luns exposed by > >>the driver may be manually scanned. > >> > >>Signed-off-by: Cathy Avery > >>--- > >> drivers/scsi/storvsc_drv.c | 6 +----- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >>diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > >>index 888e16e..fc1d6ba 100644 > >>--- a/drivers/scsi/storvsc_drv.c > >>+++ b/drivers/scsi/storvsc_drv.c > >>@@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { > >> static struct fc_function_template fc_transport_functions = { > >> .show_host_node_name = 1, > >> .show_host_port_name = 1, > >>+ .lightweight_transport = 1, > >> }; > >> #endif > >>@@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) > >> fc_transport_template = fc_attach_transport(&fc_transport_functions); > >> if (!fc_transport_template) > >> return -ENODEV; > >>- > >>- /* > >>- * Install Hyper-V specific timeout handler. > >>- */ > >>- fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > >I don't undestand how removing this is related. > > Its not related but it is also not necessary so I took it out. The > default scsi timeout handler will be used. > > I can certainly put it back. I'm not sure that we understand each other properly. Has this patch already been committed? If so, then there is no need to put it back. But it if hasn't been committed, can you resend the patches with that bit broken out into a separate patch with its own changelog? Patches should only do one thing but you're saying that it's doing two unrelated things. regards, dan carpenter