From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Date: Fri, 20 Jan 2017 10:28:50 -0800 Message-ID: <20170120182850.GE7403@atomide.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> <587C628E.7070804@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <587C628E.7070804@ti.com> Sender: linux-doc-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: Bjorn Helgaas , Jingoo Han , Joao Pinto , Arnd Bergmann , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@axis.com, linux-arm-msm@vger.kernel.org, nsekhar@ti.com List-Id: linux-arm-msm@vger.kernel.org * Kishon Vijay Abraham I [170115 22:06]: > Hi Tony, > > On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I [170112 02:35]: > >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > >> in RC mode. However in EP mode, the host system is not able to access the > >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > > > I guess ideally in the long run we would set this dynamically based on > > the selected mode, right? > > The programming sequence mentioned in the TRM w.r.t clock programming is same > for both host mode or device mode. Though we never faced any issues in host > mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. OK best to merge this with the whole series: Acked-by: Tony Lindgren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Fri, 20 Jan 2017 10:28:50 -0800 From: Tony Lindgren To: Kishon Vijay Abraham I Subject: Re: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Message-ID: <20170120182850.GE7403@atomide.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> <587C628E.7070804@ti.com> MIME-Version: 1.0 In-Reply-To: <587C628E.7070804@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Joao Pinto , Arnd Bergmann , linux-doc@vger.kernel.org, Jingoo Han , linux-arm-msm@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-samsung-soc@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: * Kishon Vijay Abraham I [170115 22:06]: > Hi Tony, > > On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I [170112 02:35]: > >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > >> in RC mode. However in EP mode, the host system is not able to access the > >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > > > I guess ideally in the long run we would set this dynamically based on > > the selected mode, right? > > The programming sequence mentioned in the TRM w.r.t clock programming is same > for both host mode or device mode. Though we never faced any issues in host > mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. OK best to merge this with the whole series: Acked-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 20 Jan 2017 10:28:50 -0800 Subject: [PATCH 36/37] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP In-Reply-To: <587C628E.7070804@ti.com> References: <1484216786-17292-1-git-send-email-kishon@ti.com> <1484216786-17292-37-git-send-email-kishon@ti.com> <20170113171537.GZ2630@atomide.com> <587C628E.7070804@ti.com> Message-ID: <20170120182850.GE7403@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Kishon Vijay Abraham I [170115 22:06]: > Hi Tony, > > On Friday 13 January 2017 10:45 PM, Tony Lindgren wrote: > > * Kishon Vijay Abraham I [170112 02:35]: > >> The PCIe programming sequence in TRM suggests CLKSTCTRL of PCIe should > >> be set to SW_WKUP. There are no issues when CLKSTCTRL is set to HW_AUTO > >> in RC mode. However in EP mode, the host system is not able to access the > >> MEMSPACE and setting the CLKSTCTRL to SW_WKUP fixes it. > > > > I guess ideally in the long run we would set this dynamically based on > > the selected mode, right? > > The programming sequence mentioned in the TRM w.r.t clock programming is same > for both host mode or device mode. Though we never faced any issues in host > mode when HW_AUTO is set, it's better to follow TRM recommended settings IMHO. OK best to merge this with the whole series: Acked-by: Tony Lindgren