Re: [PATCH 1/2] power: bq24190_charger: Check the interrupt status on resume

From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Liam Breck <kernel@networkimprov.net>,
	"Mark A . Greer" <mgreer@animalcreek.com>,
	linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
	Matt Ranostay <matt@ranostay.consulting>
Subject: Re: [PATCH 1/2] power: bq24190_charger: Check the interrupt status on resume
Date: Sun, 22 Jan 2017 02:54:41 +0100	[thread overview]
Message-ID: <20170122015441.wzsbigozefzr5wzw@earth> (raw)
In-Reply-To: <20170120220440.1971-2-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

Hi Tony,

I think your runtime_resume is missing runtime_pm_get/put_sync, see
below:

On Fri, Jan 20, 2017 at 02:04:39PM -0800, Tony Lindgren wrote:
> [...]
> +static irqreturn_t bq24190_irq_handler_thread(int irq, void *data)
> +{
> +	struct bq24190_dev_info *bdi = data;
> +
> +	bdi->irq_event = true;
> +	pm_runtime_get_sync(bdi->dev);
> +	bq24190_check_status(bdi);
> +	pm_runtime_put_sync(bdi->dev);

bq24190_check_status is called with runtime_pm enabled.

> +	bdi->irq_event = false;
>  
>  	return IRQ_HANDLED;
>  }
>
> [...]
>
> +static int bq24190_runtime_resume(struct device *dev)
> +{
> +	struct i2c_client *client = to_i2c_client(dev);
> +	struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
> +
> +	if (!bdi->initialized)
> +		return 0;
> +
> +	if (!bdi->irq_event) {
> +		dev_dbg(bdi->dev, "checking events on possible wakeirq\n");
> +		bq24190_check_status(bdi);

bq24190_check_status is called without runtime_pm enabled.

> +	}
> +
> +	return 0;
> +}
>
> [...]

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]