From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751581AbdAVTZ0 (ORCPT ); Sun, 22 Jan 2017 14:25:26 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:22398 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdAVTZT (ORCPT ); Sun, 22 Jan 2017 14:25:19 -0500 Date: Sun, 22 Jan 2017 22:24:06 +0300 From: Dan Carpenter To: Cathy Avery Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, Christoph Hellwig , devel@linuxdriverproject.org Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Message-ID: <20170122192406.GJ4454@mwanda> References: <1484771338-8903-1-git-send-email-cavery@redhat.com> <1484771338-8903-3-git-send-email-cavery@redhat.com> <20170118231555.GC4454@mwanda> <5880FD8F.8020608@redhat.com> <20170120093116.GH4398@mwanda> <5884FF21.3050801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5884FF21.3050801@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2017 at 01:51:13PM -0500, Cathy Avery wrote: > I'm sorry. In my zeal to push out this patch I have done a poor job > of communication on a number of levels. > > The first patch which deals with the fc transport changes will not > set the scsi_transport_template.eh_timed_out function directly > during lightweight fc_attach_transport(). It instead relies on > whatever was indicated as the scsi_host_template timeout handler > during inscsi_times_out() scsi_error.c. > > So yes in a sense it is related but now I believe I understand your > point. Perhaps this would fall more under the heading of post > fc_transport implementation storvsc cleanup necessitating its own > patch. > > I will break it out in the next go round. Ah... Actually it probably belongs in this patch, it just wasn't obvious to me how they were related (I'm a total newbie with this code so that's probably part of the confusion). Since you're resend the code anyway, could you just add this information to the commit message? regards, dan carpenter