All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: ast@fb.com, dh.herrmann@gmail.com, daniel@iogearbox.net,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v4 1/3] bpf: add a longest prefix match trie map implementation
Date: Sun, 22 Jan 2017 14:57:01 -0800	[thread overview]
Message-ID: <20170122225659.GB73160@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <20170121162613.4159-2-daniel@zonque.org>

On Sat, Jan 21, 2017 at 05:26:11PM +0100, Daniel Mack wrote:
> This trie implements a longest prefix match algorithm that can be used
> to match IP addresses to a stored set of ranges.
> 
> Internally, data is stored in an unbalanced trie of nodes that has a
> maximum height of n, where n is the prefixlen the trie was created
> with.
> 
> Tries may be created with prefix lengths that are multiples of 8, in
> the range from 8 to 2048. The key used for lookup and update operations
> is a struct bpf_lpm_trie_key, and the value is a uint64_t.
> 
> The code carries more information about the internal implementation.
> 
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Looks great to me.
Acked-by: Alexei Starovoitov <ast@kernel.org>

  reply	other threads:[~2017-01-22 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 16:26 [PATCH v4 0/3] bpf: add longest prefix match map Daniel Mack
2017-01-21 16:26 ` [PATCH v4 1/3] bpf: add a longest prefix match trie map implementation Daniel Mack
2017-01-22 22:57   ` Alexei Starovoitov [this message]
2017-01-23 16:39   ` Daniel Borkmann
2017-01-23 16:42     ` Daniel Mack
2017-01-21 16:26 ` [PATCH v4 2/3] bpf: Add tests for the lpm trie map Daniel Mack
2017-01-22 22:58   ` Alexei Starovoitov
2017-01-21 16:26 ` [PATCH v4 3/3] samples/bpf: add lpm-trie benchmark Daniel Mack
2017-01-22 23:02   ` Alexei Starovoitov
2017-01-23 21:11 ` [PATCH v4 0/3] bpf: add longest prefix match map David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122225659.GB73160@ast-mbp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=daniel@zonque.org \
    --cc=davem@davemloft.net \
    --cc=dh.herrmann@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.