From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVVUM-0004j2-JV for qemu-devel@nongnu.org; Sun, 22 Jan 2017 22:40:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVVUF-0006sT-8e for qemu-devel@nongnu.org; Sun, 22 Jan 2017 22:40:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cVVUF-0006rD-31 for qemu-devel@nongnu.org; Sun, 22 Jan 2017 22:40:07 -0500 Date: Mon, 23 Jan 2017 11:40:00 +0800 From: Peter Xu Message-ID: <20170123034000.GH26526@pxdev.xzpeter.org> References: <1484917736-32056-1-git-send-email-peterx@redhat.com> <1484917736-32056-19-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC v4 18/20] intel_iommu: enable vfio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: qemu-devel@nongnu.org, tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, alex.williamson@redhat.com, bd.aviv@gmail.com On Mon, Jan 23, 2017 at 10:01:11AM +0800, Jason Wang wrote: >=20 >=20 > On 2017=E5=B9=B401=E6=9C=8820=E6=97=A5 21:08, Peter Xu wrote: > >This patch is based on Aviv Ben-David ()'s patch > >upstream: > > > > "IOMMU: enable intel_iommu map and unmap notifiers" > > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01453.html > > > >However I removed/fixed some content, and added my own codes. > > > >Instead of translate() every page for iotlb invalidations (which is > >slower), we walk the pages when needed and notify in a hook function. > > > >This patch enables vfio devices for VT-d emulation. > > > >Signed-off-by: Peter Xu > >--- > > hw/i386/intel_iommu.c | 66 +++++++++++++++++++++++++++++++++= ++++------ > > include/hw/i386/intel_iommu.h | 8 ++++++ > > 2 files changed, 65 insertions(+), 9 deletions(-) >=20 > A good side effect of this patch is that it makes vhost device IOTLB wo= rks > without ATS (though may be slow). We probably need a better title :) How about I mention it in the commit message at the end? Like: "And, since we already have vhost DMAR support via device-iotlb, a natural benefit that this patch brings is that vt-d enabled vhost can live even without ATS capability now. Though more tests are needed." >=20 > And I think we should block notifiers during PSI/DSI/GLOBAL for device = with > ATS enabled. Again, would that be okay I note this in my todo list? :) Thanks, -- peterx