From: Stephen Hemminger <stephen@networkplumber.org>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ramanb@cumulusnetworks.com, jbenc@redhat.com, pshelar@ovn.org
Subject: Re: [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down
Date: Mon, 23 Jan 2017 08:59:45 -0800 [thread overview]
Message-ID: <20170123085945.36404cf0@xeon-e3> (raw)
In-Reply-To: <1484984410-3304-1-git-send-email-roopa@cumulusnetworks.com>
On Fri, 20 Jan 2017 23:40:06 -0800
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 19b1653..15b1c23 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -3276,6 +3276,12 @@ static int vxlan_netdevice_event(struct notifier_block *unused,
> vxlan_handle_lowerdev_unregister(vn, dev);
> else if (event == NETDEV_UDP_TUNNEL_PUSH_INFO)
> vxlan_push_rx_ports(dev);
> + else if (event == NETDEV_CHANGE) {
> + if (dev->netdev_ops == &vxlan_netdev_ops) {
> + if (netif_running(dev) && !netif_oper_up(dev))
> + vxlan_flush(netdev_priv(dev));
> + }
> + }
Looks correct.
Maybe logic would be clearer with a switch() statement here.
next prev parent reply other threads:[~2017-01-23 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 7:40 [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down Roopa Prabhu
2017-01-21 7:40 ` [PATCH cumulus-4.1.y 2/5] vxlan: don't replace fdb entry if nothing changed Roopa Prabhu
2017-01-23 17:02 ` Stephen Hemminger
2017-01-24 0:14 ` Roopa Prabhu
2017-01-21 7:40 ` [PATCH cumulus-4.1.y 3/5] vxlan: enforce precedence for static over dynamic fdb entry Roopa Prabhu
2017-01-21 7:40 ` [PATCH cumulus-4.1.y 4/5] vxlan: don't flush static fdb entries on admin down Roopa Prabhu
2017-01-21 9:25 ` kbuild test robot
2017-01-21 7:40 ` [PATCH cumulus-4.1.y 5/5] vxlan: do not age static remote mac entries Roopa Prabhu
2017-01-21 7:41 ` [PATCH cumulus-4.1.y 1/5] vxlan: flush fdb entries on oper down Roopa Prabhu
2017-01-21 8:54 ` kbuild test robot
2017-01-21 8:58 ` kbuild test robot
2017-01-23 16:59 ` Stephen Hemminger [this message]
2017-01-24 0:11 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123085945.36404cf0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=ramanb@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.