From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101AbdAWMKO (ORCPT ); Mon, 23 Jan 2017 07:10:14 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33908 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbdAWMKN (ORCPT ); Mon, 23 Jan 2017 07:10:13 -0500 Date: Mon, 23 Jan 2017 12:14:12 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Olof Johansson , Alessandro Zummo , Alexandre Belloni , Stephen Barber Subject: Re: [PATCH v2 4/4] mfd: cros_ec: add RTC as mfd subdevice Message-ID: <20170123121412.GL16020@dell> References: <20170119123032.24679-1-enric.balletbo@collabora.com> <20170119123032.24679-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170119123032.24679-4-enric.balletbo@collabora.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 Jan 2017, Enric Balletbo i Serra wrote: > From: Stephen Barber > > If the EC supports RTC host commands, expose an RTC device. > > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > --- > drivers/platform/chrome/cros_ec_dev.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) This still needs an Ack. > diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c > index 47268ec..ebe029d 100644 > --- a/drivers/platform/chrome/cros_ec_dev.c > +++ b/drivers/platform/chrome/cros_ec_dev.c > @@ -383,6 +383,24 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec) > kfree(msg); > } > > +static const struct mfd_cell cros_ec_rtc_devs[] = { > + { > + .name = "cros-ec-rtc", > + .id = -1, > + }, > +}; > + > +static void cros_ec_rtc_register(struct cros_ec_dev *ec) > +{ > + int ret; > + > + ret = mfd_add_devices(ec->dev, 0, cros_ec_rtc_devs, > + ARRAY_SIZE(cros_ec_rtc_devs), > + NULL, 0, NULL); > + if (ret) > + dev_err(ec->dev, "failed to add cros-ec-rtc device: %d\n", ret); > +} > + > static int ec_device_probe(struct platform_device *pdev) > { > int retval = -ENOMEM; > @@ -441,6 +459,10 @@ static int ec_device_probe(struct platform_device *pdev) > if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) > cros_ec_sensors_register(ec); > > + /* check whether this EC instance has RTC host command support */ > + if (cros_ec_check_features(ec, EC_FEATURE_RTC)) > + cros_ec_rtc_register(ec); > + > return 0; > > dev_reg_failed: -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com. [2a00:1450:400c:c09::22e]) by gmr-mx.google.com with ESMTPS id c129si588823wme.1.2017.01.23.04.10.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jan 2017 04:10:12 -0800 (PST) Received: by mail-wm0-x22e.google.com with SMTP id r144so151457025wme.1 for ; Mon, 23 Jan 2017 04:10:12 -0800 (PST) Date: Mon, 23 Jan 2017 12:14:12 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Olof Johansson , Alessandro Zummo , Alexandre Belloni , Stephen Barber Subject: [rtc-linux] Re: [PATCH v2 4/4] mfd: cros_ec: add RTC as mfd subdevice Message-ID: <20170123121412.GL16020@dell> References: <20170119123032.24679-1-enric.balletbo@collabora.com> <20170119123032.24679-4-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20170119123032.24679-4-enric.balletbo@collabora.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Thu, 19 Jan 2017, Enric Balletbo i Serra wrote: > From: Stephen Barber >=20 > If the EC supports RTC host commands, expose an RTC device. >=20 > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > --- > drivers/platform/chrome/cros_ec_dev.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) This still needs an Ack. > diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chr= ome/cros_ec_dev.c > index 47268ec..ebe029d 100644 > --- a/drivers/platform/chrome/cros_ec_dev.c > +++ b/drivers/platform/chrome/cros_ec_dev.c > @@ -383,6 +383,24 @@ static void cros_ec_sensors_register(struct cros_ec_= dev *ec) > kfree(msg); > } > =20 > +static const struct mfd_cell cros_ec_rtc_devs[] =3D { > + { > + .name =3D "cros-ec-rtc", > + .id =3D -1, > + }, > +}; > + > +static void cros_ec_rtc_register(struct cros_ec_dev *ec) > +{ > + int ret; > + > + ret =3D mfd_add_devices(ec->dev, 0, cros_ec_rtc_devs, > + ARRAY_SIZE(cros_ec_rtc_devs), > + NULL, 0, NULL); > + if (ret) > + dev_err(ec->dev, "failed to add cros-ec-rtc device: %d\n", ret); > +} > + > static int ec_device_probe(struct platform_device *pdev) > { > int retval =3D -ENOMEM; > @@ -441,6 +459,10 @@ static int ec_device_probe(struct platform_device *p= dev) > if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE)) > cros_ec_sensors_register(ec); > =20 > + /* check whether this EC instance has RTC host command support */ > + if (cros_ec_check_features(ec, EC_FEATURE_RTC)) > + cros_ec_rtc_register(ec); > + > return 0; > =20 > dev_reg_failed: --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. ---=20 You received this message because you are subscribed to the Google Groups "= rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.