All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 0/3] Boolean comparison and exthdr existence match support
Date: Mon, 23 Jan 2017 13:57:47 +0100	[thread overview]
Message-ID: <20170123125747.GA2017@salvia> (raw)
In-Reply-To: <20170117221007.14951-1-phil@nwl.cc>

Hi Phil,

On Tue, Jan 17, 2017 at 11:10:04PM +0100, Phil Sutter wrote:
> The following series adds two distinct features to nftables, though
> since the second one depends on presence of the first one this is
> submitted as a series.
> 
> Patch 1 adds support for a boolean variant of relational expression.
> It's OP is strictly implicit and determined by RHS being a boolean
> expression. It depends on a related kernel patch adding support for
> NFT_CMP_BOOL to nft_cmp.c.

If the problem is that we lack of context from the delinearize path,
then I would prefer if you scratch one bit from the fib flags to
indicate that we want a true (1)/false (0) return value. Just like we
plan to do with exthdr. This should require a small kernel patch for
nft_fib I think.

Thus, we can skip this ad hoc update for nft_cmp which seems to me
that it's only there to help us get the context that we lack from the
delinearize step.

Then, from the delinearize path, if this fib/exthdr flag is set, we
attach the corresponding datatype to the expression based on this new
flag.

Thanks.

  parent reply	other threads:[~2017-01-23 12:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 22:10 [nft PATCH 0/3] Boolean comparison and exthdr existence match support Phil Sutter
2017-01-17 22:10 ` [nft PATCH 1/3] Implement boolean comparison in relational expression Phil Sutter
2017-01-17 22:10 ` [nft PATCH 2/3] exthdr: Add support for exthdr specific flags Phil Sutter
2017-01-17 22:10 ` [nft PATCH 3/3] exthdr: Implement exthdr existence check Phil Sutter
2017-01-23 12:57 ` Pablo Neira Ayuso [this message]
2017-02-06 14:26   ` [nft PATCH 0/3] Boolean comparison and exthdr existence match support Phil Sutter
2017-02-06 17:16     ` Pablo Neira Ayuso
2017-02-07  2:28       ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123125747.GA2017@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.