From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbdAWRsq (ORCPT ); Mon, 23 Jan 2017 12:48:46 -0500 Received: from mail-qt0-f175.google.com ([209.85.216.175]:35647 "EHLO mail-qt0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbdAWRso (ORCPT ); Mon, 23 Jan 2017 12:48:44 -0500 Date: Mon, 23 Jan 2017 12:48:41 -0500 From: Sean Paul To: Chris Zhong Cc: dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, mark.rutland@arm.com, devicetree@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, pawel.moll@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function Message-ID: <20170123174841.GB25789@trickycodes.roam.corp.google.com> References: <1484907051-7159-1-git-send-email-zyw@rock-chips.com> <1484907051-7159-4-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484907051-7159-4-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2017 at 06:10:49PM +0800, Chris Zhong wrote: > The MIPI DSI do not need check the validity of resolution, the max > resolution should depend VOP. Hence, remove rk3288_mipi_dsi_mode_valid > here. Does vop actually enforce this, though? I see that mode_config.max_width is 4096, but there is no bounds checking in mode_fixup(). The connector is currently rejecting everything greater than 2047. So I think you're going to regress behavior here. Sean > > Signed-off-by: Chris Zhong > --- > > Changes in v3: None > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 39 ---------------------------------- > 1 file changed, 39 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index a93ce97..6f0e252 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -278,8 +278,6 @@ struct dw_mipi_dsi_plat_data { > u32 grf_dsi0_mode; > u32 grf_dsi0_mode_reg; > unsigned int max_data_lanes; > - enum drm_mode_status (*mode_valid)(struct drm_connector *connector, > - struct drm_display_mode *mode); > }; > > struct dw_mipi_dsi { > @@ -1081,23 +1079,8 @@ static int dw_mipi_dsi_connector_get_modes(struct drm_connector *connector) > return drm_panel_get_modes(dsi->panel); > } > > -static enum drm_mode_status dw_mipi_dsi_mode_valid( > - struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - struct dw_mipi_dsi *dsi = con_to_dsi(connector); > - > - enum drm_mode_status mode_status = MODE_OK; > - > - if (dsi->pdata->mode_valid) > - mode_status = dsi->pdata->mode_valid(connector, mode); > - > - return mode_status; > -} > - > static struct drm_connector_helper_funcs dw_mipi_dsi_connector_helper_funcs = { > .get_modes = dw_mipi_dsi_connector_get_modes, > - .mode_valid = dw_mipi_dsi_mode_valid, > }; > > static void dw_mipi_dsi_drm_connector_destroy(struct drm_connector *connector) > @@ -1168,33 +1151,11 @@ static int rockchip_mipi_parse_dt(struct dw_mipi_dsi *dsi) > return 0; > } > > -static enum drm_mode_status rk3288_mipi_dsi_mode_valid( > - struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* > - * The VID_PKT_SIZE field in the DSI_VID_PKT_CFG > - * register is 11-bit. > - */ > - if (mode->hdisplay > 0x7ff) > - return MODE_BAD_HVALUE; > - > - /* > - * The V_ACTIVE_LINES field in the DSI_VTIMING_CFG > - * register is 11-bit. > - */ > - if (mode->vdisplay > 0x7ff) > - return MODE_BAD_VVALUE; > - > - return MODE_OK; > -} > - > static struct dw_mipi_dsi_plat_data rk3288_mipi_dsi_drv_data = { > .dsi0_en_bit = RK3288_DSI0_SEL_VOP_LIT, > .dsi1_en_bit = RK3288_DSI1_SEL_VOP_LIT, > .grf_switch_reg = RK3288_GRF_SOC_CON6, > .max_data_lanes = 4, > - .mode_valid = rk3288_mipi_dsi_mode_valid, > }; > > static struct dw_mipi_dsi_plat_data rk3399_mipi_dsi_drv_data = { > -- > 2.6.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Mon, 23 Jan 2017 12:48:41 -0500 Subject: [PATCH v3 3/5] drm/rockchip/dsi: remove mode_valid function In-Reply-To: <1484907051-7159-4-git-send-email-zyw@rock-chips.com> References: <1484907051-7159-1-git-send-email-zyw@rock-chips.com> <1484907051-7159-4-git-send-email-zyw@rock-chips.com> Message-ID: <20170123174841.GB25789@trickycodes.roam.corp.google.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 20, 2017 at 06:10:49PM +0800, Chris Zhong wrote: > The MIPI DSI do not need check the validity of resolution, the max > resolution should depend VOP. Hence, remove rk3288_mipi_dsi_mode_valid > here. Does vop actually enforce this, though? I see that mode_config.max_width is 4096, but there is no bounds checking in mode_fixup(). The connector is currently rejecting everything greater than 2047. So I think you're going to regress behavior here. Sean > > Signed-off-by: Chris Zhong > --- > > Changes in v3: None > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 39 ---------------------------------- > 1 file changed, 39 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index a93ce97..6f0e252 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -278,8 +278,6 @@ struct dw_mipi_dsi_plat_data { > u32 grf_dsi0_mode; > u32 grf_dsi0_mode_reg; > unsigned int max_data_lanes; > - enum drm_mode_status (*mode_valid)(struct drm_connector *connector, > - struct drm_display_mode *mode); > }; > > struct dw_mipi_dsi { > @@ -1081,23 +1079,8 @@ static int dw_mipi_dsi_connector_get_modes(struct drm_connector *connector) > return drm_panel_get_modes(dsi->panel); > } > > -static enum drm_mode_status dw_mipi_dsi_mode_valid( > - struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - struct dw_mipi_dsi *dsi = con_to_dsi(connector); > - > - enum drm_mode_status mode_status = MODE_OK; > - > - if (dsi->pdata->mode_valid) > - mode_status = dsi->pdata->mode_valid(connector, mode); > - > - return mode_status; > -} > - > static struct drm_connector_helper_funcs dw_mipi_dsi_connector_helper_funcs = { > .get_modes = dw_mipi_dsi_connector_get_modes, > - .mode_valid = dw_mipi_dsi_mode_valid, > }; > > static void dw_mipi_dsi_drm_connector_destroy(struct drm_connector *connector) > @@ -1168,33 +1151,11 @@ static int rockchip_mipi_parse_dt(struct dw_mipi_dsi *dsi) > return 0; > } > > -static enum drm_mode_status rk3288_mipi_dsi_mode_valid( > - struct drm_connector *connector, > - struct drm_display_mode *mode) > -{ > - /* > - * The VID_PKT_SIZE field in the DSI_VID_PKT_CFG > - * register is 11-bit. > - */ > - if (mode->hdisplay > 0x7ff) > - return MODE_BAD_HVALUE; > - > - /* > - * The V_ACTIVE_LINES field in the DSI_VTIMING_CFG > - * register is 11-bit. > - */ > - if (mode->vdisplay > 0x7ff) > - return MODE_BAD_VVALUE; > - > - return MODE_OK; > -} > - > static struct dw_mipi_dsi_plat_data rk3288_mipi_dsi_drv_data = { > .dsi0_en_bit = RK3288_DSI0_SEL_VOP_LIT, > .dsi1_en_bit = RK3288_DSI1_SEL_VOP_LIT, > .grf_switch_reg = RK3288_GRF_SOC_CON6, > .max_data_lanes = 4, > - .mode_valid = rk3288_mipi_dsi_mode_valid, > }; > > static struct dw_mipi_dsi_plat_data rk3399_mipi_dsi_drv_data = { > -- > 2.6.3 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS