From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net PATCH v5 1/6] virtio_net: use dev_kfree_skb for small buffer XDP receive Date: Tue, 24 Jan 2017 14:43:28 -0500 (EST) Message-ID: <20170124.144328.2195698124358175034.davem@davemloft.net> References: <20170117221443.20280.62546.stgit@john-Precision-Tower-5810> <20170117221950.20280.39496.stgit@john-Precision-Tower-5810> <20170123230809-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: john.fastabend@gmail.com, jasowang@redhat.com, john.r.fastabend@intel.com, netdev@vger.kernel.org, alexei.starovoitov@gmail.com, daniel@iogearbox.net To: mst@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57170 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbdAXTn3 (ORCPT ); Tue, 24 Jan 2017 14:43:29 -0500 In-Reply-To: <20170123230809-mutt-send-email-mst@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: "Michael S. Tsirkin" Date: Mon, 23 Jan 2017 23:08:35 +0200 > On Tue, Jan 17, 2017 at 02:19:50PM -0800, John Fastabend wrote: >> In the small buffer case during driver unload we currently use >> put_page instead of dev_kfree_skb. Resolve this by adding a check >> for virtnet mode when checking XDP queue type. Also name the >> function so that the code reads correctly to match the additional >> check. >> >> Fixes: bb91accf2733 ("virtio-net: XDP support for small buffers") >> Signed-off-by: John Fastabend >> Acked-by: Jason Wang > > Acked-by: Michael S. Tsirkin > > I think we definitely want this one in -net as it's > a bugfix. This whole series is a bug fix, we must have adjust_header XDP support in the virtio_net driver before v4.10 goes out, it is a requires base feature for XDP.