From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbdAWWsB (ORCPT ); Mon, 23 Jan 2017 17:48:01 -0500 Received: from mail.kernel.org ([198.145.29.136]:46258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdAWWsA (ORCPT ); Mon, 23 Jan 2017 17:48:00 -0500 Date: Tue, 24 Jan 2017 07:47:46 +0900 From: Masami Hiramatsu To: SF Markus Elfring Cc: Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , He Kuang , Ingo Molnar , Jiri Olsa , Milian Wolff , Peter Zijlstra , Ravi Bangoria , Wang Nan , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/4] perf probe: Delete an unnecessary assignment in try_to_find_absolute_address() Message-Id: <20170124074746.93a88c7163c0e55e42cc84c8@kernel.org> In-Reply-To: <0ede09ec-79b6-c8bd-5b20-02c63ed98aab@users.sourceforge.net> References: <0ede09ec-79b6-c8bd-5b20-02c63ed98aab@users.sourceforge.net> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Jan 2017 16:24:06 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 23 Jan 2017 15:10:19 +0100 > > Remove an error code assignment which is redundant in an if branch for > the handling of a memory allocation failure because the same value was set > for the local variable "err" before. > > Signed-off-by: Markus Elfring This looks good to me :) Acked-by: Masami Hiramatsu Thanks! > --- > tools/perf/util/probe-event.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 6c7508337fe8..5a34c93b818a 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2956,10 +2956,9 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, > > tev->nargs = pev->nargs; > tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs); > - if (!tev->args) { > - err = -ENOMEM; > + if (!tev->args) > goto errout; > - } > + > for (i = 0; i < tev->nargs; i++) > copy_to_probe_trace_arg(&tev->args[i], &pev->args[i]); > > -- > 2.11.0 > -- Masami Hiramatsu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Mon, 23 Jan 2017 22:47:46 +0000 Subject: Re: [PATCH 2/4] perf probe: Delete an unnecessary assignment in try_to_find_absolute_address() Message-Id: <20170124074746.93a88c7163c0e55e42cc84c8@kernel.org> List-Id: References: <0ede09ec-79b6-c8bd-5b20-02c63ed98aab@users.sourceforge.net> In-Reply-To: <0ede09ec-79b6-c8bd-5b20-02c63ed98aab@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Adrian Hunter , Alexander Shishkin , Arnaldo Carvalho de Melo , He Kuang , Ingo Molnar , Jiri Olsa , Milian Wolff , Peter Zijlstra , Ravi Bangoria , Wang Nan , LKML , kernel-janitors@vger.kernel.org On Mon, 23 Jan 2017 16:24:06 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 23 Jan 2017 15:10:19 +0100 > > Remove an error code assignment which is redundant in an if branch for > the handling of a memory allocation failure because the same value was set > for the local variable "err" before. > > Signed-off-by: Markus Elfring This looks good to me :) Acked-by: Masami Hiramatsu Thanks! > --- > tools/perf/util/probe-event.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 6c7508337fe8..5a34c93b818a 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2956,10 +2956,9 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, > > tev->nargs = pev->nargs; > tev->args = zalloc(sizeof(struct probe_trace_arg) * tev->nargs); > - if (!tev->args) { > - err = -ENOMEM; > + if (!tev->args) > goto errout; > - } > + > for (i = 0; i < tev->nargs; i++) > copy_to_probe_trace_arg(&tev->args[i], &pev->args[i]); > > -- > 2.11.0 > -- Masami Hiramatsu