From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750853AbdAXLfZ (ORCPT ); Tue, 24 Jan 2017 06:35:25 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34914 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdAXLfX (ORCPT ); Tue, 24 Jan 2017 06:35:23 -0500 Date: Tue, 24 Jan 2017 12:35:17 +0100 From: Richard Cochran To: Marcelo Tosatti Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Radim Krcmar , Miroslav Lichvar Subject: Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross timestamps infrastructure Message-ID: <20170124113517.GA2341@localhost.localdomain> References: <20170120122025.665985919@redhat.com> <20170120122503.746158230@redhat.com> <20170120202502.GA10368@localhost.localdomain> <20170123131913.GA28104@amt.cnet> <20170123184415.GA2158@localhost.localdomain> <20170124112326.GA30511@amt.cnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170124112326.GA30511@amt.cnet> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2017 at 09:23:29AM -0200, Marcelo Tosatti wrote: > I'm resending v5 with native support for ->gettime and > ->getcrosststamps. And can you please drop the "fake" PTP_SYS_OFFSET stuff? Here is another reason why this is illogical. The application can choose how many samples to take during PTP_SYS_OFFSET. It will choose more samples if it wants a better picture of the offsets, but in that case the "fake" samples would cause more computation in the kernel for no added benefit. Thanks, Richard