Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
	qemu-devel@nongnu.org, amit.shah@redhat.com
Subject: Re: [Qemu-devel] [PATCH 01/17] migration: transform remained DPRINTF into trace_
Date: Tue, 24 Jan 2017 12:20:55 +0000	[thread overview]
Message-ID: <20170124122055.GG20224@work-vm> (raw)
In-Reply-To: <f77369a0-8818-0115-ec1b-13dcd0c594f2@redhat.com>

* Eric Blake (eblake@redhat.com) wrote:
> On 01/23/2017 03:32 PM, Juan Quintela wrote:
> 
> In the subject: s/remained/remaining/
> 
> > So we can remove DPRINTF() macro
> > 
> > Signed-off-by: Juan Quintela <quintela@redhat.com>
> > ---
> >  migration/ram.c        | 18 ++++--------------
> >  migration/trace-events |  4 ++++
> >  2 files changed, 8 insertions(+), 14 deletions(-)
> > 
> > diff --git a/migration/ram.c b/migration/ram.c
> > index a1c8089..ef8fadf 100644
> > --- a/migration/ram.c
> > +++ b/migration/ram.c
> > @@ -45,14 +45,6 @@
> >  #include "qemu/rcu_queue.h"
> >  #include "migration/colo.h"
> > 
> > -#ifdef DEBUG_MIGRATION_RAM
> > -#define DPRINTF(fmt, ...) \
> > -    do { fprintf(stdout, "migration_ram: " fmt, ## __VA_ARGS__); } while (0)
> > -#else
> > -#define DPRINTF(fmt, ...) \
> > -    do { } while (0)
> 
> Yay - you're getting rid of the bitrot pattern in this file!
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

This change doesn't need the rest of the series so,
queued.
(Fixed up 'remained')

Dave

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK