From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Weinehall Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Tue, 24 Jan 2017 14:29:00 +0200 Message-ID: <20170124122900.hd5cmzbzll7vkplp@boom> References: <20170120182205.8141-1-ville.syrjala@linux.intel.com> <20170120182205.8141-5-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05F1E6E12F for ; Tue, 24 Jan 2017 12:29:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170120182205.8141-5-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMjAsIDIwMTcgYXQgMDg6MjE6NTVQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBMZXQncyBjbGVhbiB1cCB0aGUgbWVzcyB3ZSBoYXZl IGluIHRoZSBpZiBsYWRkZXIgdGhhdCBhc3NpZ25zIHRoZQo+IC5nZXRfY2RjbGsoKSBob29rcy4g VGhlIGdyb3VwaW5nIG9mIHRoZSBwbGF0Zm9ybXMgYnkgdGhlIGZ1bmN0aW9uCj4gcmVzdWx0cyBp biBhIHRoaW5nIHRoYXQncyBub3QgcmVhbGx5IGxlZ2libGUsIHNvIGxldCdzIGRvIGl0IHRoZQo+ IG90aGVyIHdheSBhcm91bmQgYW5kIG9yZGVyIHRoZSBpZiBsYWRkZXIgYnkgcGxhdGZvcm0gYW5k IGR1cGxpY2F0ZQo+IHdoYXRldmVyIGFzc2lnbm1lbnRzIHdlIG5lZWQuCj4gCj4gVG8gZnVydGhl ciBhdm9pZCBjb25mdXNpb24gd2l0aCB0aGUgZnVuY3Rpb24gbmFtZXMgbGV0J3MgcmVuYW1lCj4g dGhlbSB0byBqdXN0IGZpeGVkXzxmcmVxPl9nZXRfY2RjbGsoKS4gVGhlIG90aGVyIG9wdGlvbiB3 b3VsZAo+IGJlIHRvIGR1cGxpY2F0ZSB0aGUgZnVuY3Rpb25zIGVudGlyZWx5IGJ1dCBpdCBzZWVt cyBxdWl0ZQo+IHBvaW50bGVzcyB0byBkbyB0aGF0IHNpbmNlIGVhY2ggb25lIGp1c3QgcmV0dXJu cyBhIGZpeGVkIHZhbHVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEFuZGVyIENvbnNlbHZh biBkZSBPbGl2ZWlyYSA8Y29uc2VsdmFuMkBnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQxICsrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGJkMGZk YzA0YmM5Mi4uNjY4YzYxYWQ0NWE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IEBAIC03MzY2LDIyICs3MzY2LDIyIEBAIHN0YXRpYyBpbnQgdmFsbGV5dmlld19nZXRf Y2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCQkJICAgICAgQ0NL X0RJU1BMQVlfQ0xPQ0tfQ09OVFJPTCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaWxrX2dldF9j ZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyBpbnQgZml4 ZWRfNDUwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IHsKPiAgCXJldHVybiA0NTAwMDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgaTk0NV9nZXRfY2Rj bGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50IGZpeGVk XzQwMG1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7 Cj4gIAlyZXR1cm4gNDAwMDAwOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGk5MTVfZ2V0X2NkY2xr KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIGludCBmaXhlZF8z MzNtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ ICAJcmV0dXJuIDMzMzMzMzsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBpOXh4X21pc2NfZ2V0X2Nk Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIGludCBmaXhl ZF8yMDBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAg ewo+ICAJcmV0dXJuIDIwMDAwMDsKPiAgfQo+IEBAIC03NDMxLDcgKzc0MzEsNyBAQCBzdGF0aWMg aW50IGk5MTVnbV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICAJfQo+ICB9Cj4gIAo+IC1zdGF0aWMgaW50IGk4NjVfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIGludCBmaXhlZF8yNjZtaHpfZ2V0X2NkY2xr KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJcmV0dXJuIDI2NjY2 NzsKPiAgfQoKSG93IGFib3V0IHJlb3JkZXJpbmcgdGhpcyBhbmQgdGhlIG9uZSBhYm92ZSB0byBo YXZlIHRoZSBjbG9ja3MgaW4Kc3RyaWN0bHkgZGVzY2VuZGluZyBvcmRlcj8KCj4gQEAgLTc0NzQs NyArNzQ3NCw3IEBAIHN0YXRpYyBpbnQgaTg1eF9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICAJcmV0dXJuIDA7Cj4gIH0KClNpbWlsYXJseSwgbW92ZSB0aGlz IG9uZSBkb3duLgoKPiAtc3RhdGljIGludCBpODMwX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyBpbnQgZml4ZWRfMTMzbWh6X2dldF9jZGNsayhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCXJldHVybiAxMzMzMzM7 Cj4gIH0KPiBAQCAtMTYxODAsMzIgKzE2MTgwLDM5IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5 X2hvb2tzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlkZXZfcHJpdi0+ ZGlzcGxheS5nZXRfY2RjbGsgPSBoYXN3ZWxsX2dldF9jZGNsazsKPiAgCWVsc2UgaWYgKElTX1ZB TExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ICAJCWRldl9w cml2LT5kaXNwbGF5LmdldF9jZGNsayA9IHZhbGxleXZpZXdfZ2V0X2NkY2xrOwo+ICsJZWxzZSBp ZiAoSVNfR0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiArCQlkZXZf cHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrOwo+ICAJZWxz ZSBpZiAoSVNfR0VONShkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xr ID0gaWxrX2dldF9jZGNsazsKPiAtCWVsc2UgaWYgKElTX0k5NDVHKGRldl9wcml2KSB8fCBJU19J OTY1RyhkZXZfcHJpdikgfHwKPiAtCQkgSVNfR0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdF KGRldl9wcml2KSkKPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTQ1X2dldF9j ZGNsazsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF80NTBtaHpfZ2V0 X2NkY2xrOwo+ICAJZWxzZSBpZiAoSVNfR000NShkZXZfcHJpdikpCj4gIAkJZGV2X3ByaXYtPmRp c3BsYXkuZ2V0X2NkY2xrID0gZ200NV9nZXRfY2RjbGs7Cj4gKwllbHNlIGlmIChJU19HNFgoZGV2 X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGczM19nZXRfY2RjbGs7 Cj4gIAllbHNlIGlmIChJU19JOTY1R00oZGV2X3ByaXYpKQo+ICAJCWRldl9wcml2LT5kaXNwbGF5 LmdldF9jZGNsayA9IGk5NjVnbV9nZXRfY2RjbGs7Cj4gKwllbHNlIGlmIChJU19JOTY1RyhkZXZf cHJpdikpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dl dF9jZGNsazsKPiAgCWVsc2UgaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkKPiAgCQlkZXZfcHJp di0+ZGlzcGxheS5nZXRfY2RjbGsgPSBwbnZfZ2V0X2NkY2xrOwo+IC0JZWxzZSBpZiAoSVNfRzMz KGRldl9wcml2KSB8fCBJU19HNFgoZGV2X3ByaXYpKQo+ICsJZWxzZSBpZiAoSVNfRzMzKGRldl9w cml2KSkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnMzNfZ2V0X2NkY2xrOwo+ IC0JZWxzZSBpZiAoSVNfSTkxNUcoZGV2X3ByaXYpKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5Lmdl dF9jZGNsayA9IGk5MTVfZ2V0X2NkY2xrOwo+IC0JZWxzZSBpZiAoSVNfSTk0NUdNKGRldl9wcml2 KSB8fCBJU19JODQ1RyhkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xr ID0gaTl4eF9taXNjX2dldF9jZGNsazsKPiArCWVsc2UgaWYgKElTX0k5NDVHTShkZXZfcHJpdikp Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMjAwbWh6X2dldF9jZGNs azsKPiArCWVsc2UgaWYgKElTX0k5NDVHKGRldl9wcml2KSkKPiArCQlkZXZfcHJpdi0+ZGlzcGxh eS5nZXRfY2RjbGsgPSBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrOwo+ICAJZWxzZSBpZiAoSVNfSTkx NUdNKGRldl9wcml2KSkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTE1Z21f Z2V0X2NkY2xrOwo+ICsJZWxzZSBpZiAoSVNfSTkxNUcoZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2 LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzMzM21oel9nZXRfY2RjbGs7Cj4gIAllbHNlIGlm IChJU19JODY1RyhkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0g aTg2NV9nZXRfY2RjbGs7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRf MjY2bWh6X2dldF9jZGNsazsKPiAgCWVsc2UgaWYgKElTX0k4NVgoZGV2X3ByaXYpKQo+ICAJCWRl dl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk4NXhfZ2V0X2NkY2xrOwo+ICsJZWxzZSAgaWYg KElTX0k4NDVHKGRldl9wcml2KSkKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBm aXhlZF8yMDBtaHpfZ2V0X2NkY2xrOwo+ICAJZWxzZSB7IC8qIDgzMCAqLwo+ICAJCVdBUk4oIUlT X0k4MzAoZGV2X3ByaXYpLCAiVW5rbm93biBwbGF0Zm9ybS4gQXNzdW1pbmcgMTMzIE1IeiBDRENM S1xuIik7Cj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTgzMF9nZXRfY2RjbGs7 Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMTMzbWh6X2dldF9jZGNs azsKPiAgCX0KPiAgCj4gIAlpZiAoSVNfR0VONShkZXZfcHJpdikpIHsKPiAtLSAKPiAyLjEwLjIK PiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==