From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Jarry Subject: Re: [PATCH] mk: optimize directory dependencies Date: Tue, 24 Jan 2017 13:31:06 +0100 Message-ID: <20170124123106.uprr62tzlwquhbvj@6wind.com> References: <20170123181813.00567e47@platinum> <1485191953-2613-1-git-send-email-olivier.matz@6wind.com> <20170124111949.6jcif4uliwg6bgxv@6wind.com> <20170124112633.GA156840@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: Olivier Matz , dev@dpdk.org, ferruh.yigit@intel.com, thomas.monjalon@6wind.com To: Bruce Richardson Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5E3081023 for ; Tue, 24 Jan 2017 13:31:13 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r144so206421782wme.1 for ; Tue, 24 Jan 2017 04:31:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <20170124112633.GA156840@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, 2017-01-24, Bruce Richardson: >what are the differences in the patches like when doing a build rather >than just a config? If the build is minutes long because of slow IO, >is the extra 10 seconds really going to make that much of a difference? I agree there is no significant difference in total build time (config included) when using -j8 (about ~15s). And I understand your concern about the complexity of the patch in the second solution. But the way dependencies are computed is overly complex and I feel that parallelizing is just hiding dust under the carpet. The result after the second solution is cleaner (to me): we get rid of an obscure shell script and we stop piping make output to files thus restoring the possibility to use make -d to debug problems. And while the goal is to reduce the config time, why not go all the way? -- Robin