From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751147AbdAXV3C (ORCPT ); Tue, 24 Jan 2017 16:29:02 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34316 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdAXV2u (ORCPT ); Tue, 24 Jan 2017 16:28:50 -0500 Date: Tue, 24 Jan 2017 13:28:49 -0800 From: Andrew Morton To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Hugh Dickins , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Peter Zijlstra Subject: Re: [PATCH 01/12] uprobes: split THPs before trying replace them Message-Id: <20170124132849.73135e8c6e9572be00dbbe79@linux-foundation.org> In-Reply-To: <20170124162824.91275-2-kirill.shutemov@linux.intel.com> References: <20170124162824.91275-1-kirill.shutemov@linux.intel.com> <20170124162824.91275-2-kirill.shutemov@linux.intel.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" wrote: > For THPs page_check_address() always fails. It's better to split them > first before trying to replace. So what does this mean. uprobes simply fails to work when trying to place a probe into a THP memory region? How come nobody noticed (and reported) this when using the feature? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f198.google.com (mail-pf0-f198.google.com [209.85.192.198]) by kanga.kvack.org (Postfix) with ESMTP id 3D68B6B026C for ; Tue, 24 Jan 2017 16:28:51 -0500 (EST) Received: by mail-pf0-f198.google.com with SMTP id f144so252215907pfa.3 for ; Tue, 24 Jan 2017 13:28:51 -0800 (PST) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id g17si18599811pgi.336.2017.01.24.13.28.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 13:28:50 -0800 (PST) Date: Tue, 24 Jan 2017 13:28:49 -0800 From: Andrew Morton Subject: Re: [PATCH 01/12] uprobes: split THPs before trying replace them Message-Id: <20170124132849.73135e8c6e9572be00dbbe79@linux-foundation.org> In-Reply-To: <20170124162824.91275-2-kirill.shutemov@linux.intel.com> References: <20170124162824.91275-1-kirill.shutemov@linux.intel.com> <20170124162824.91275-2-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Andrea Arcangeli , Hugh Dickins , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Peter Zijlstra On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" wrote: > For THPs page_check_address() always fails. It's better to split them > first before trying to replace. So what does this mean. uprobes simply fails to work when trying to place a probe into a THP memory region? How come nobody noticed (and reported) this when using the feature? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org