From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750942AbdAXSyS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Jan 2017 13:54:18 -0500
Received: from mail.kernel.org ([198.145.29.136]:48868 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750723AbdAXSyR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Jan 2017 13:54:17 -0500
Date: Tue, 24 Jan 2017 15:54:10 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/5] perf, tools, script: Add brstackasm output for
 branch stacks
Message-ID: <20170124185410.GF10340@kernel.org>
References: <20170119014150.19218-1-andi@firstfloor.org>
 <20170119014150.19218-6-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170119014150.19218-6-andi@firstfloor.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Jan 18, 2017 at 05:41:50PM -0800, Andi Kleen escreveu:
> +	memset(&al, 0, sizeof(al));
> +	if (end - start > MAXBB - MAXINSN) {
> +		if (last)
> +			printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> +					start, end);
> +		else
> +			printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
> +					start, end, end - start);
> +		return 0;

Those are multiline if/else blocks, one has to use {}, additionally (end
- start) should be, just like the other bits PRI, fixing...

This actually broke the build in some distros, like fedora:24
crossbuilding to ARC-uClibc.

- Arnaldo