From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: He Kuang <hekuang@huawei.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
mhiramat@kernel.org, wangnan0@huawei.com,
bintian.wang@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Introduce regs_query_register_offset() for arm64
Date: Tue, 24 Jan 2017 16:09:08 -0300 [thread overview]
Message-ID: <20170124190908.GG10340@kernel.org> (raw)
In-Reply-To: <20170124182515.GA26744@arm.com>
Em Tue, Jan 24, 2017 at 06:25:18PM +0000, Will Deacon escreveu:
> On Tue, Jan 24, 2017 at 10:30:15AM +0000, He Kuang wrote:
> > Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> > regs_query_register_offset() to convert register name to offset for
> > arm64, so the BPF prologue feature is ready to use.
> >
> > This patch also changes the 'dwarfnum' to 'offset' in register table,
> > so the related functions are consistent with x86.
> >
> > Signed-off-by: He Kuang <hekuang@huawei.com>
> It would've been nice to have been cc'd on this. In future, please at least
> cc linux-arm-kernel for patches directly changing arm/arm64 code.
> > + GPR_OFFSET_NAME(30),
> > + {.name = "lr", .offset = offsetof(struct user_pt_regs, regs[30])},
> > + REG_OFFSET_NAME(sp),
> Don't sp and lr need the leading '%'?
> > + REG_OFFSET_NAME(pc),
> > + REG_OFFSET_NAME(pstate),
> The AArch64 DWARF spec says that DWARF register 32 is "RESERVED" and
> register 33 is the ELR, so these pc/pstate entries are wrong.
> However, with those changes, I think this patch can simply be ignored and
> mainline is doing the right thing.
Ok, thanks for checking, dropping this patch then.
- Arnaldo
next prev parent reply other threads:[~2017-01-24 19:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:30 [PATCH 0/2] Support bpf prologue for arm64 He Kuang
2017-01-24 10:30 ` [PATCH 1/2] perf probe: Fix wrong register name " He Kuang
2017-01-24 19:11 ` Arnaldo Carvalho de Melo
2017-01-25 9:22 ` Will Deacon
2017-01-26 1:24 ` Masami Hiramatsu
2017-01-26 15:28 ` [tip:perf/core] " tip-bot for He Kuang
2017-05-03 8:54 ` [PATCH 1/2] " Pratyush Anand
2017-01-24 10:30 ` [PATCH 2/2] perf tools: Introduce regs_query_register_offset() " He Kuang
2017-01-24 18:25 ` Will Deacon
2017-01-24 19:09 ` Arnaldo Carvalho de Melo [this message]
2017-01-25 7:23 ` [PATCH 2/2 v2] perf tools: Enable bpf prologue " He Kuang
2017-01-25 7:23 ` He Kuang
2017-01-25 13:32 ` Will Deacon
2017-01-25 13:32 ` Will Deacon
2017-01-26 1:49 ` Masami Hiramatsu
2017-01-26 1:49 ` Masami Hiramatsu
2017-01-26 16:52 ` Will Deacon
2017-01-26 16:52 ` Will Deacon
2017-01-26 19:31 ` Arnaldo Carvalho de Melo
2017-01-26 19:31 ` Arnaldo Carvalho de Melo
2017-02-03 11:08 ` Hekuang
2017-02-03 11:08 ` Hekuang
2017-01-26 1:51 ` Masami Hiramatsu
2017-01-26 1:51 ` Masami Hiramatsu
2017-01-25 7:26 ` [PATCH 2/2] perf tools: Introduce regs_query_register_offset() " Hekuang
2017-01-24 15:56 ` [PATCH 0/2] Support bpf prologue " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124190908.GG10340@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bintian.wang@huawei.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.