From: David Miller <davem@davemloft.net>
To: oneukum@suse.com
Cc: hayeswang@realtek.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: NAPI on USB network drivers
Date: Wed, 25 Jan 2017 14:32:26 -0500 (EST) [thread overview]
Message-ID: <20170125.143226.525018584694503090.davem@davemloft.net> (raw)
In-Reply-To: <1485336881.16604.2.camel@suse.com>
From: Oliver Neukum <oneukum@suse.com>
Date: Wed, 25 Jan 2017 10:34:41 +0100
> looking at r8152 I noticed that it uses NAPI. I never considered
> this for the generic USB networking code as you cannot disable
> interrupts for USB. Is it still worth it? What are the benefits?
I think it's not a good approach for getting GRO.
Exactly because of the issue you raise, in that USB drivers
cannot stop the URBs from coming in while running their poll
method.
prev parent reply other threads:[~2017-01-25 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 9:34 NAPI on USB network drivers Oliver Neukum
[not found] ` <1485336881.16604.2.camel-IBi9RG/b67k@public.gmane.org>
2017-01-25 9:39 ` Hayes Wang
[not found] ` <0835B3720019904CB8F7AA43166CEEB201A134A7-JIZ+AM9kKNzKeZCINmmWEypo8c9IxeqyAjHCUHv49ws@public.gmane.org>
2017-01-25 13:33 ` Oliver Hartkopp
2017-01-25 20:57 ` Alexander Duyck
2017-01-26 18:59 ` Oliver Hartkopp
2017-01-25 14:13 ` Eric Dumazet
[not found] ` <1485353591.5145.8.camel-XN9IlZ5yJG9HTL0Zs8A6p+yfmBU6pStAUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2017-01-26 1:43 ` Hayes Wang
2017-01-25 19:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125.143226.525018584694503090.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.