All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list
Date: Tue, 24 Jan 2017 21:28:05 -0800	[thread overview]
Message-ID: <20170125052805.GJ9134@birch.djwong.org> (raw)
In-Reply-To: <1560023.HPyvzjyxDL@localhost.localdomain>

On Wed, Jan 25, 2017 at 10:31:07AM +0530, Chandan Rajendra wrote:
> On Tuesday, January 24, 2017 09:22:10 AM Darrick J. Wong wrote:
> > Fix a stupid typo in the original commit.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  tools/find-api-violations.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/find-api-violations.sh b/tools/find-api-violations.sh
> > index 7937749..b4b8de5 100755
> > --- a/tools/find-api-violations.sh
> > +++ b/tools/find-api-violations.sh
> > @@ -6,7 +6,7 @@
> > 
> >  # NOTE: This script doesn't look for API violations in function parameters.
> > 
> > -tool_dirs="copy db estimate fs fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> > +tool_dirs="copy db estimate fsr fsck fsr growfs io mdrestore mkfs quota repair rtcp"
> >
>                                
> fsr is already part of the list. With this patch, we now have a duplicate
> entry. Or, Am I missing something very obvious?

Pah, it's missing logprint too.

Ok, respin....

--D

> 
> -- 
> chandan
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2017-01-25  5:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 17:22 [PATCH] tools/find-api-violations: fix fs -> fsr in the directory list Darrick J. Wong
2017-01-24 17:31 ` Christoph Hellwig
2017-01-25  5:01 ` Chandan Rajendra
2017-01-25  5:28   ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125052805.GJ9134@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.