From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA5A381F30 for ; Wed, 25 Jan 2017 03:19:55 -0800 (PST) Date: Wed, 25 Jan 2017 03:19:52 -0800 From: Christoph Hellwig Subject: Re: [PATCH v5] DAX: enable iostat for read/write Message-ID: <20170125111952.GA11978@infradead.org> References: <20170112183848.23159-1-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170112183848.23159-1-toshi.kani@hpe.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Toshi Kani Cc: linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, Joe Perches , akpm@linux-foundation.org List-ID: On Thu, Jan 12, 2017 at 11:38:48AM -0700, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still does not support the DAX mmap path as it allows > user applications to access directly. NAK. DAX I/O should not be accounted for block device statistics. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbdAYLT6 (ORCPT ); Wed, 25 Jan 2017 06:19:58 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:43184 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdAYLT4 (ORCPT ); Wed, 25 Jan 2017 06:19:56 -0500 Date: Wed, 25 Jan 2017 03:19:52 -0800 From: Christoph Hellwig To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-nvdimm@ml01.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, Joe Perches , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5] DAX: enable iostat for read/write Message-ID: <20170125111952.GA11978@infradead.org> References: <20170112183848.23159-1-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112183848.23159-1-toshi.kani@hpe.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 11:38:48AM -0700, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still does not support the DAX mmap path as it allows > user applications to access directly. NAK. DAX I/O should not be accounted for block device statistics. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:43184 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdAYLT4 (ORCPT ); Wed, 25 Jan 2017 06:19:56 -0500 Date: Wed, 25 Jan 2017 03:19:52 -0800 From: Christoph Hellwig To: Toshi Kani Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, Joe Perches , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5] DAX: enable iostat for read/write Message-ID: <20170125111952.GA11978@infradead.org> References: <20170112183848.23159-1-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112183848.23159-1-toshi.kani@hpe.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jan 12, 2017 at 11:38:48AM -0700, Toshi Kani wrote: > DAX IO path does not support iostat, but its metadata IO path does. > Therefore, iostat shows metadata IO statistics only, which has been > confusing to users. > > Add iostat support to the DAX read/write path. > > Note, iostat still does not support the DAX mmap path as it allows > user applications to access directly. NAK. DAX I/O should not be accounted for block device statistics.