From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdAYOGt (ORCPT ); Wed, 25 Jan 2017 09:06:49 -0500 Received: from mga05.intel.com ([192.55.52.43]:19265 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdAYOGr (ORCPT ); Wed, 25 Jan 2017 09:06:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,284,1477983600"; d="scan'208";a="35293396" Date: Wed, 25 Jan 2017 16:06:41 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Andrzej Hajda Cc: Inki Dae , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Daniel Vetter Subject: Re: [PATCH 6/7] drm/exynos/decon5433: signal vblank only on odd fields Message-ID: <20170125140641.GU31595@intel.com> References: <1484895145-511-1-git-send-email-a.hajda@samsung.com> <1484895145-511-7-git-send-email-a.hajda@samsung.com> <20170120135540.GC31595@intel.com> <953193f0-484e-0457-baf4-e42b44a3f147@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <953193f0-484e-0457-baf4-e42b44a3f147@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 10:15:16AM +0100, Andrzej Hajda wrote: > On 20.01.2017 14:55, Ville Syrjälä wrote: > > On Fri, Jan 20, 2017 at 07:52:24AM +0100, Andrzej Hajda wrote: > >> In case of interlace mode irq is generated for odd and even fields, but > >> vblank should be signaled only for the last emitted field. > > I'm pretty sure most drivers signal it for both fields. At least i915 > > does. > > The question is which behavior is correct? I have not found any clear > statement in the documentation, or drm core code. That's very typical for us unfortunately. I would say what we should do what i915 does. It allows more flexibility in how you use the hardware. Eg. then you can actually scan out interlaced material to an interlaced display and not mess up the fields, and you can also do 3:2 pulldown type of stuff. Or you can even just stuff progressive frames down the pipe at field rate. One problem with interlaced stuff is that we don't have any field indication in the events, nor do we have a way to flip on a specific field. I tried to specify the latter for the SETPLANE ioctl way back when, but it didn't end up being implemented and now we would need something different for atomic. > I have guessed that since vblank event is used to signal end of scan-out > of buffer it should be called after scan-out of whole buffer - in case > of interlaced mode after scan-out of 2nd field. Each field has a proper vertical blanking interval, so you'd just end up totally wasting one of them. > Maybe my assumption is wrong, in such case this patch should be dropped > and mixer driver also should be fixed, but before doing that it would be > good to know for sure how it should be handled correctly. > > Regards > Andrzej -- Ville Syrjälä Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/7] drm/exynos/decon5433: signal vblank only on odd fields Date: Wed, 25 Jan 2017 16:06:41 +0200 Message-ID: <20170125140641.GU31595@intel.com> References: <1484895145-511-1-git-send-email-a.hajda@samsung.com> <1484895145-511-7-git-send-email-a.hajda@samsung.com> <20170120135540.GC31595@intel.com> <953193f0-484e-0457-baf4-e42b44a3f147@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <953193f0-484e-0457-baf4-e42b44a3f147@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kyungmin Park , dri-devel@lists.freedesktop.org, Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gTW9uLCBKYW4gMjMsIDIwMTcgYXQgMTA6MTU6MTZBTSArMDEwMCwgQW5kcnplaiBIYWpkYSB3 cm90ZToKPiBPbiAyMC4wMS4yMDE3IDE0OjU1LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiBP biBGcmksIEphbiAyMCwgMjAxNyBhdCAwNzo1MjoyNEFNICswMTAwLCBBbmRyemVqIEhhamRhIHdy b3RlOgo+ID4+IEluIGNhc2Ugb2YgaW50ZXJsYWNlIG1vZGUgaXJxIGlzIGdlbmVyYXRlZCBmb3Ig b2RkIGFuZCBldmVuIGZpZWxkcywgYnV0Cj4gPj4gdmJsYW5rIHNob3VsZCBiZSBzaWduYWxlZCBv bmx5IGZvciB0aGUgbGFzdCBlbWl0dGVkIGZpZWxkLgo+ID4gSSdtIHByZXR0eSBzdXJlIG1vc3Qg ZHJpdmVycyBzaWduYWwgaXQgZm9yIGJvdGggZmllbGRzLiBBdCBsZWFzdCBpOTE1Cj4gPiBkb2Vz Lgo+IAo+IFRoZSBxdWVzdGlvbiBpcyB3aGljaCBiZWhhdmlvciBpcyBjb3JyZWN0PyBJIGhhdmUg bm90IGZvdW5kIGFueSBjbGVhcgo+IHN0YXRlbWVudCBpbiB0aGUgZG9jdW1lbnRhdGlvbiwgb3Ig ZHJtIGNvcmUgY29kZS4KClRoYXQncyB2ZXJ5IHR5cGljYWwgZm9yIHVzIHVuZm9ydHVuYXRlbHku CgpJIHdvdWxkIHNheSB3aGF0IHdlIHNob3VsZCBkbyB3aGF0IGk5MTUgZG9lcy4gSXQgYWxsb3dz IG1vcmUgZmxleGliaWxpdHkKaW4gaG93IHlvdSB1c2UgdGhlIGhhcmR3YXJlLiBFZy4gdGhlbiB5 b3UgY2FuIGFjdHVhbGx5IHNjYW4gb3V0CmludGVybGFjZWQgbWF0ZXJpYWwgdG8gYW4gaW50ZXJs YWNlZCBkaXNwbGF5IGFuZCBub3QgbWVzcyB1cCB0aGUgZmllbGRzLAphbmQgeW91IGNhbiBhbHNv IGRvIDM6MiBwdWxsZG93biB0eXBlIG9mIHN0dWZmLiBPciB5b3UgY2FuIGV2ZW4ganVzdApzdHVm ZiBwcm9ncmVzc2l2ZSBmcmFtZXMgZG93biB0aGUgcGlwZSBhdCBmaWVsZCByYXRlLgoKT25lIHBy b2JsZW0gd2l0aCBpbnRlcmxhY2VkIHN0dWZmIGlzIHRoYXQgd2UgZG9uJ3QgaGF2ZSBhbnkgZmll bGQKaW5kaWNhdGlvbiBpbiB0aGUgZXZlbnRzLCBub3IgZG8gd2UgaGF2ZSBhIHdheSB0byBmbGlw IG9uIGEgc3BlY2lmaWMKZmllbGQuIEkgdHJpZWQgdG8gc3BlY2lmeSB0aGUgbGF0dGVyIGZvciB0 aGUgU0VUUExBTkUgaW9jdGwgd2F5CmJhY2sgd2hlbiwgYnV0IGl0IGRpZG4ndCBlbmQgdXAgYmVp bmcgaW1wbGVtZW50ZWQgYW5kIG5vdyB3ZSB3b3VsZApuZWVkIHNvbWV0aGluZyBkaWZmZXJlbnQg Zm9yIGF0b21pYy4KCj4gSSBoYXZlIGd1ZXNzZWQgdGhhdCBzaW5jZSB2YmxhbmsgZXZlbnQgaXMg dXNlZCB0byBzaWduYWwgZW5kIG9mIHNjYW4tb3V0Cj4gb2YgYnVmZmVyIGl0IHNob3VsZCBiZSBj YWxsZWQgYWZ0ZXIgc2Nhbi1vdXQgb2Ygd2hvbGUgYnVmZmVyIC0gaW4gY2FzZQo+IG9mIGludGVy bGFjZWQgbW9kZSBhZnRlciBzY2FuLW91dCBvZiAybmQgZmllbGQuCgpFYWNoIGZpZWxkIGhhcyBh IHByb3BlciB2ZXJ0aWNhbCBibGFua2luZyBpbnRlcnZhbCwgc28geW91J2QganVzdCBlbmQgdXAK dG90YWxseSB3YXN0aW5nIG9uZSBvZiB0aGVtLgoKPiBNYXliZSBteSBhc3N1bXB0aW9uIGlzIHdy b25nLCBpbiBzdWNoIGNhc2UgdGhpcyBwYXRjaCBzaG91bGQgYmUgZHJvcHBlZAo+IGFuZCBtaXhl ciBkcml2ZXIgYWxzbyBzaG91bGQgYmUgZml4ZWQsIGJ1dCBiZWZvcmUgZG9pbmcgdGhhdCBpdCB3 b3VsZCBiZQo+IGdvb2QgdG8ga25vdyBmb3Igc3VyZSBob3cgaXQgc2hvdWxkIGJlIGhhbmRsZWQg Y29ycmVjdGx5Lgo+IAo+IFJlZ2FyZHMKPiBBbmRyemVqCgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK