From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF Date: Wed, 25 Jan 2017 18:29:55 +0000 Message-ID: <20170125182955.uznr5ehpx4dabcon@sirena.org.uk> References: <20170125000641.25520-1-furquan@chromium.org> <20170125124911.dxveow7bo3zw5jcc@sirena.org.uk> <20170125182319.GB25470@leverpostej> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qoxy7iombucoqky4" Return-path: Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41126 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdAYSaU (ORCPT ); Wed, 25 Jan 2017 13:30:20 -0500 Content-Disposition: inline In-Reply-To: <20170125182319.GB25470@leverpostej> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mark Rutland Cc: Furquan Shaikh , "Rafael J. Wysocki" , "Rafael J . Wysocki" , Liam Girdwood , Tony Lindgren , Dmitry Torokhov , Len Brown , Greg Kroah-Hartman , Lorenzo Pieralisi , Hanjun Guo , Will Deacon , Rob Herring , Sathyanarayana Nujella , Heikki Krogerus , Adam Thomson , Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, ACPI --qoxy7iombucoqky4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 25, 2017 at 06:23:20PM +0000, Mark Rutland wrote: > On Wed, Jan 25, 2017 at 08:56:42AM -0800, Furquan Shaikh wrote: > > That is the reason why the recent change to add ACPI support to fixed > > regulators was done > > (https://github.com/torvalds/linux/blob/master/drivers/regulator/fixed.c#L100). > To be honest, I'm surprised this got merged. My understanding was that it was instantiated from another device as an implementation detail of that device, letting it say "this GPIO should be handled as a regulator". > Mark, this was added in this cycle; can we please rip that out for now? If it's instantiated directly we probably should. > We can certainly come up with something that allows drivers to support > both, but trying to do this without updating drivers opens a huge set of > problems. I think there's a reasonable chance that any ACPI specs could be written in such a way as to allow transparent support in Linux, the main thing I'd worry about is naming issues. --qoxy7iombucoqky4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAliI7qIACgkQJNaLcl1U h9Ak9gf9Fv8FQw78/lGnnfUEXDJpzb1xaYReLretUjNYUM6Kn7B+rcKrUg7kogZE itGupSiNw1rcwgV2MrazN+SYKYxImjDtpYtZWilWIuO8giyFjn2qadLKxDE1ca1f GleeWCiAh4Kbfz5+qNzwnD4EkyIud40hTehGvvBxkoBhqfFHvslKk/5RDcRPWD7T AukmpXC4yCFXaq93sQ7seS5xwnGQ94fr+tVYccKiR+dz1mf7jfATUH7rAFBRHyA0 Zvgx6qIHvw3xBjm31TlLxj8wHAhN2DfgK1XAAOl88mHHuDxM95OQD6pfGeUsPakf UHB5vPru63TslnVDMRfQI3QuEa1vJw== =BSGp -----END PGP SIGNATURE----- --qoxy7iombucoqky4-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbdAYSaW (ORCPT ); Wed, 25 Jan 2017 13:30:22 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:41126 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752175AbdAYSaU (ORCPT ); Wed, 25 Jan 2017 13:30:20 -0500 Date: Wed, 25 Jan 2017 18:29:55 +0000 From: Mark Brown To: Mark Rutland Cc: Furquan Shaikh , "Rafael J. Wysocki" , "Rafael J . Wysocki" , Liam Girdwood , Tony Lindgren , Dmitry Torokhov , Len Brown , Greg Kroah-Hartman , Lorenzo Pieralisi , Hanjun Guo , Will Deacon , Rob Herring , Sathyanarayana Nujella , Heikki Krogerus , Adam Thomson , Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, ACPI Devel Maling List , Linux Kernel Mailing List , Linux OMAP Mailing List , Aaron Durbin , dlaurie@chromium.org Message-ID: <20170125182955.uznr5ehpx4dabcon@sirena.org.uk> References: <20170125000641.25520-1-furquan@chromium.org> <20170125124911.dxveow7bo3zw5jcc@sirena.org.uk> <20170125182319.GB25470@leverpostej> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qoxy7iombucoqky4" Content-Disposition: inline In-Reply-To: <20170125182319.GB25470@leverpostej> X-Cookie: A man's best friend is his dogma. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 0/7] Implement generic regulator constraints parsing for ACPI and OF X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qoxy7iombucoqky4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 25, 2017 at 06:23:20PM +0000, Mark Rutland wrote: > On Wed, Jan 25, 2017 at 08:56:42AM -0800, Furquan Shaikh wrote: > > That is the reason why the recent change to add ACPI support to fixed > > regulators was done > > (https://github.com/torvalds/linux/blob/master/drivers/regulator/fixed.c#L100). > To be honest, I'm surprised this got merged. My understanding was that it was instantiated from another device as an implementation detail of that device, letting it say "this GPIO should be handled as a regulator". > Mark, this was added in this cycle; can we please rip that out for now? If it's instantiated directly we probably should. > We can certainly come up with something that allows drivers to support > both, but trying to do this without updating drivers opens a huge set of > problems. I think there's a reasonable chance that any ACPI specs could be written in such a way as to allow transparent support in Linux, the main thing I'd worry about is naming issues. --qoxy7iombucoqky4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAliI7qIACgkQJNaLcl1U h9Ak9gf9Fv8FQw78/lGnnfUEXDJpzb1xaYReLretUjNYUM6Kn7B+rcKrUg7kogZE itGupSiNw1rcwgV2MrazN+SYKYxImjDtpYtZWilWIuO8giyFjn2qadLKxDE1ca1f GleeWCiAh4Kbfz5+qNzwnD4EkyIud40hTehGvvBxkoBhqfFHvslKk/5RDcRPWD7T AukmpXC4yCFXaq93sQ7seS5xwnGQ94fr+tVYccKiR+dz1mf7jfATUH7rAFBRHyA0 Zvgx6qIHvw3xBjm31TlLxj8wHAhN2DfgK1XAAOl88mHHuDxM95OQD6pfGeUsPakf UHB5vPru63TslnVDMRfQI3QuEa1vJw== =BSGp -----END PGP SIGNATURE----- --qoxy7iombucoqky4--